|
| 1 | +# Node.js Foundation Diagnostics Working Group Meeting 2018-09-05 Minutes |
| 2 | + |
| 3 | +## Attendees |
| 4 | +* Michael Dawson (@mhdawson) |
| 5 | +* Jan Krems (@jkrems) |
| 6 | +* Thomas Watson (@watson) |
| 7 | +* Matheus Marchini (@mmarchini) |
| 8 | +* Stephen Belanger (@qard) |
| 9 | +* Peter Marton (@hekike) |
| 10 | +* @mike-kaufman |
| 11 | +* @ofrobots |
| 12 | +* @bridgeAR |
| 13 | + |
| 14 | + |
| 15 | +## Links |
| 16 | +- **This Meeting**: |
| 17 | + - Minutes: https://github.com/nodejs/diagnostics/blob/master/wg-meetings/2018-09-05.md |
| 18 | + - Notes: |
| 19 | + - You Tube: http://youtu.be/UgHFJsTviF8 |
| 20 | +- **Previous Meeting**: |
| 21 | + - Minutes: https://github.com/nodejs/diagnostics/blob/master/wg-meetings/2018-08-22.md |
| 22 | + - Notes: https://docs.google.com/document/d/1b7InhqjUTZY0c9jYrpFgzo0xwDgbZ4LjtLPH98ZU4kg/edit |
| 23 | + - You Tube: http://youtu.be/0MJ_VIKzoJg |
| 24 | + |
| 25 | +## Agenda |
| 26 | + |
| 27 | +Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. |
| 28 | + |
| 29 | +## nodejs/node |
| 30 | + - http2: diagnostic use cases [#21888](https://github.com/nodejs/node/issues/21888) |
| 31 | + - tweeted out, no response |
| 32 | + - closed issue |
| 33 | + |
| 34 | +### nodejs/diagnostics |
| 35 | + |
| 36 | + - Diag WG Deep Dives - topics [#168](https://github.com/nodejs/diagnostics/issues/168) |
| 37 | + - @mike-kaufman to schedule deep-dive on async-context formalizations. |
| 38 | + |
| 39 | + - Diagnostics "Best Practices" Guide? - [#211](https://github.com/nodejs/diagnostics/issues/211) |
| 40 | + - general agreement that this will be a good thing |
| 41 | + - at a minimum if it is just a list of links, that's a start that we can improve on |
| 42 | + - leave on agenda & try to make progress |
| 43 | + |
| 44 | + - Expectation about tier of support from diagnostic tools and VMs [#157](https://github.com/nodejs/diagnostics/issues/157) |
| 45 | + - original PR that lists tools has landed |
| 46 | + - now tools need to be categorized into some tier (they're all uncategorized now) |
| 47 | + - we will leave open to track progress |
| 48 | + - next steps are to start moving tools into tiers |
| 49 | + - there's a PR open on node-report moving into core |
| 50 | + - Code event listeners can move up since we now have tests |
| 51 | + - Mateus or Peter to open a PR on this |
| 52 | + |
| 53 | + - \[async_hooks\] stable API - tracking issue [#124](https://github.com/nodejs/diagnostics/issues/124) |
| 54 | + - Open PR [21313](github.com/nodejs/node/pull/21313), eliminates need for destroy callback & significantly improves perf |
| 55 | + - this is stalled |
| 56 | + - current pushback is some http parser resources are pooled and shared across requests |
| 57 | + |
| 58 | + - Async-context formalization and diagnostics support [#107](https://github.com/nodejs/diagnostics/issues/107) |
| 59 | + - PR https://github.com/nodejs/diagnostics/pull/197 open, would love feedback |
| 60 | + - will schedule a deep-dive |
| 61 | + |
| 62 | + - \[trace_event\] tracking issue [#84](https://github.com/nodejs/diagnostics/issues/84) |
| 63 | + - @mhdawson pinged James, didn't hear back |
| 64 | + - some things in this list are done, some things are missing |
| 65 | + - @ofrobots said he'd try to find some time to clean up |
| 66 | + - one thing that is missing is production-quality implementation for an event store |
| 67 | + - perfeto is project that chromium is moving to |
| 68 | + - some refactoring to change v8 to accept a pluggable implementation for the store would simplify things here. |
| 69 | + |
| 70 | + - discussion on how to keep llnode working |
| 71 | + - matheus is looking into how to metadata for llnode is emitted |
| 72 | + - trying to find a new way to analyze core dumps |
| 73 | + - last 4 or 5 v8 updates broke llnode |
| 74 | + - 1st prototype that Matheus did had poor perf |
| 75 | + - calculated memory offsets of various properties |
| 76 | + - trying another approach to use an API on v8 and let v8 do the calculations efficiently. |
0 commit comments