Add test verifying edited CI comments

Author: phillipj

lib/github-comment.js

@@ -26,6 +26,11 @@ const getPRComments = `query getPRComments($owner: String!, $repo: String!, $num
   }
 }`
 
+function graphQlIdToRestId(nodeId) {
+  const decoded = Buffer.from(nodeId, 'base64').toString();
+  return decoded.match(/\d+$/)[0]
+}
+
 exports.getFirstBotComment = function getFirstBotComment ({ owner, repo, number }, cursor = null) {
   return GQL(getPRComments, { owner, repo, number, cursor }).then(data => {
     const { nodes, pageInfo } = data.repository.pullRequest.comments
@@ -43,8 +48,9 @@ exports.getFirstBotComment = function getFirstBotComment ({ owner, repo, number
 exports.createPrComment = function createPrComment ({ owner, repo, number, logger }, body) {
   exports.getFirstBotComment({ owner, repo, number, logger }).then((comment) => {
     if (comment) {
-      const { id, body: oldBody } = comment
+      const { id: nodeId, body: oldBody } = comment
       const newBody = `${oldBody}\n${body}`
+      const id = graphQlIdToRestId(nodeId)
       return githubClient.issues.editComment({ owner, repo, id, body: newBody })
     }
     return githubClient.issues.createComment({ owner, repo, number, body })

test/_fixtures/pull-request-three-comments-gql.json

@@ -0,0 +1,41 @@
+{
+  "data": {
+    "repository": {
+      "pullRequest": {
+        "comments": {
+          "nodes": [
+            {
+              "id": "MDEyOklzc3VlQ29tbWVudDQ4ODM3NzY4Mg==",
+              "body": "Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3416",
+              "viewerDidAuthor": true
+            },
+            {
+              "id": "MDEyOklzc3VlQ29tbWVudDQ4ODM3ODU5MA==",
+              "body": "/to @nodejs/crypto  @nodejs/lts ",
+              "viewerDidAuthor": false
+            },
+            {
+              "id": "MDEyOklzc3VlQ29tbWVudDQ4ODc4MDk5Nw==",
+              "body": "CI: https://ci.nodejs.org/job/node-test-pull-request/22894/",
+              "viewerDidAuthor": true
+            }
+          ],
+          "pageInfo": {
+            "endCursor": "Y3Vyc29yOnYyOpHOHSI0xQ==",
+            "hasNextPage": false
+          }
+        },
+        "labels": {
+          "nodes": [
+            {
+              "name": "C++"
+            },
+            {
+              "name": "tls"
+            }
+          ]
+        }
+      }
+    }
+  }
+}

test/integration/push-jenkins-update.test.js

@@ -166,6 +166,39 @@ tap.test('Posts a CI comment in the related PR when Jenkins build is named node-
     })
 })
 
+tap.test('Edits existing comment in the related PR when Jenkins build is named node-test-pull-request', (t) => {
+  const fixture = readFixture('jenkins-test-pull-request-success-payload.json')
+  const commentScope = nock('https://api.github.com')
+    .filteringPath(ignoreQueryParams)
+    .patch('/repos/nodejs/node/issues/comments/488377682', {
+      body: 'Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3416\nCI: https://ci.nodejs.org/job/node-test-pull-request/21633/'
+    })
+    .reply(200)
+
+  nock('https://api.github.com')
+    .filteringPath(ignoreQueryParams)
+    .post('/graphql')
+    .reply(200, readFixture('pull-request-three-comments-gql.json'))
+
+  // we don't care about asserting the scopes below, just want to stop the requests from actually being sent
+  setupGetCommitsMock('node')
+  nock('https://api.github.com')
+    .filteringPath(ignoreQueryParams)
+    .post('/repos/nodejs/node/statuses/8a5fec2a6bade91e544a30314d7cf21f8a200de1')
+    .reply(201)
+
+  t.plan(1)
+
+  supertest(app)
+    .post('/node/jenkins/start')
+    .send(fixture)
+    .expect(201)
+    .end((err, res) => {
+      commentScope.done()
+      t.equal(err, null)
+    })
+})
+
 tap.test('Responds with 400 / "Bad request" when incoming request has invalid payload', (t) => {
   const fixture = readFixture('invalid-payload.json')