Skip to content

Add support for PR updates #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phillipj opened this issue Apr 6, 2016 · 5 comments
Closed

Add support for PR updates #11

phillipj opened this issue Apr 6, 2016 · 5 comments

Comments

@phillipj
Copy link
Member

phillipj commented Apr 6, 2016

Currently the bot only responds to created PR's. Adding support for reporting Travis build status on PR changes (new or forced commits) would be great.
@phillipj
Copy link
Member Author

phillipj commented Apr 6, 2016

As the webhooks have currently been configured to "send all events", the bot already gets notified about updates, it just ignores them...

https://github.com/nodejs-github-bot/github-bot/blob/master/server.js#L15 would be particularly interresting

@MylesBorins
Copy link
Contributor

I'd be up for taking this on if you want to assign it to me. Can potentially hack ion it from 10k feet this afternoon 😄

@phillipj phillipj assigned phillipj and MylesBorins and unassigned phillipj Apr 6, 2016
@phillipj
Copy link
Member Author

@Fishrock123 did you fix updates with your last changes in #15?

@Fishrock123
Copy link
Contributor

@phillipj Oh, yes actually: https://github.com/nodejs-github-bot/github-bot/blob/master/scripts/display-travis-status.js#L9-L10

@Fishrock123
Copy link
Contributor

Note: I have not tested this with the PR-commenting, only the PR status updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MylesBorins @Fishrock123 @phillipj