remove traceSyncIO from process #2143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be curious to see if anyone (not sure why?) is actually using this though. It seems to me like this would be a semver-major change if that is the case. |
mscdex
added
c++
|
LGTM This property was added not that long ago by myself, and shouldn't have been. I don't see a conceivable way this could break any modules. If it does then we can add it back and wait for a major. |
|
works for me LGTM |
|
Pile-on LGTM. |
bnoordhuis
pushed a commit
that referenced
this pull request
Jul 9, 2015
PR-URL: #2143 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
|
Thanks, landed in 5ee4881. |
bnoordhuis
pushed a commit
that referenced
this pull request
Jul 9, 2015
PR-URL: #2143 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
PR-URL: nodejs#2143 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is unnecessary as per @trevnorris