Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Localize comment in HTML #225

Closed
osslate opened this issue Feb 20, 2015 · 6 comments
Closed

Localize comment in HTML #225

osslate opened this issue Feb 20, 2015 · 6 comments

Comments

@osslate
Copy link

osslate commented Feb 20, 2015

There's a HTML comment on every page: <!-- See something you like? Want to help? Visit https://github.com/iojs/website to contribute -->

Currently this comment is kept as is on every localised version. Might be nice to have this comment translated too, and perhaps a link to the relevant localisation repo.

@osslate osslate changed the title Localize comment in Localize comment in HTML Feb 20, 2015
@bnb
Copy link

bnb commented Feb 20, 2015

+1. Wrote out an entire message suggesting to link to the localized repo's page instead of the main repo, then saw that you had already written that. Oops.

Anyway, I think linking to the localized repo is a good idea. Something we probably want to leave up to the localization teams is if they want to include both the English and localized versions, if they think they might also have a decent English-speaking readership as well (as I know some do). That way, people who can contribute to this repo, without a language barrier in the way, are able to if they'd like to.

@mikeal
Copy link
Contributor

mikeal commented Feb 20, 2015

+1 the "localizations" shouldn't just be translations but should actually include additional content and pointers relevant to that language community.

@therebelrobot
Copy link
Contributor

+1 we need to add this into the build process. When I originally built it, I thought we'd only be handling text content, and built to that spec. This is another use case that might be good to implement a different templating engine like jade or handlebars.

@snostorm
Copy link
Contributor

Haha, I think this specific line landed as a result of my needing an "invisible change" when we were needing to do a test deploy of the website project.

Anyway, ya, eventually the template solution will probably need a bit more flexibility. My actually answer to this is: eventually I'd like every page to have an "edit/contribute/make this page better" type link on it which points right to the Markdown file in the related repo. Re: translations, we could maybe do something like: Help edit this page (en) or in the other sites link to both sources Aide modifier cette page (fr, en).

@snostorm
Copy link
Contributor

snostorm commented Mar 3, 2015

See #257 for this

@snostorm
Copy link
Contributor

snostorm commented Mar 4, 2015

Closing as #257 has landed.

@snostorm snostorm closed this as completed Mar 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants