Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

out of band meeting to handle objections from upstream #297

Closed
MylesBorins opened this issue Mar 18, 2019 · 10 comments
Closed

out of band meeting to handle objections from upstream #297

MylesBorins opened this issue Mar 18, 2019 · 10 comments

Comments

@MylesBorins
Copy link
Contributor

Do people have time this week to meet and try and reach consensus about the changes requested from upstream? I would like see if we could resolve the conflicts within our team in a timely fashion and not require another week and a half before we can iterate

Here's a doodle: https://doodle.com/poll/fhv643f6g38y8wn9

@SMotaal
Copy link

SMotaal commented Mar 19, 2019

Possible discussion points I would personally consider relevant:

@GeoffreyBooth
Copy link
Member

We also need to discuss my/Myles’ proposal regarding --package-type, and either get consensus on it or on something else that otherwise addresses the upstream need. It appears that we can’t let a week or two go by without responding to their concerns.

@MylesBorins
Copy link
Contributor Author

@nodejs/modules

It looks like the best times we have right now and 10 / 11 am ET tomorrow... although @ljharb is unable to make either meeting... since we can't find a single time that has all folks with objections nor quorum I'm not convinced the meeting is going to be very effective.

Based on that I'd like to suggest the following with regard to upstream implementation... mostly implying that we move forward with what upstream has requested, and assume there are no upstream objections we get the branch ready to land Wednesday and then have one last review as a team before we land it (and celebrate).

Based on current upstream objections these would be the changes, compared to what we originally proposed

  • removal of the -m flag
  • renaming --type to --entry-type

I think it is reasonable for us to move forward with these if we have a basic consensus between all groups right now and then buckle down on quickly iterating as a group on specific changes to the above if we want to make them... we can still get them in before 12.x if we work fast enough.

Thoughts?

@MylesBorins
Copy link
Contributor Author

To be VERY clear. Please explicitly object if you have any issues with the above plan. Our ability to move quickly here is dependent on communication

@SMotaal
Copy link

SMotaal commented Mar 21, 2019

@MylesBorins Can I be more explicit… I have no objections on what the team agrees to upstream but would like to go into the meeting to discuss the two points you state above.

Also, I feel we need to allocate a firm timebox to align expectations where needed — ie how objections within and in spite of our process by team members affect our collective efforts and commitments.

@MylesBorins
Copy link
Contributor Author

@SMotaal I'm sorry but that wasn't exactly clear to me. No one seems to be objecting to what we have upstream right now, are you stating you still want to have the out of band meeting?

@SMotaal
Copy link

SMotaal commented Mar 23, 2019

@MylesBorins failing to find my good hat for making the right assumptions or at least not misunderstanding your initial post, sure that was my own intent from the post, but always yielding to the teams overall heading — so we are good there no need for apologies and I appreciate how hard it is juggling everything this past week.

I would revise my statement, maybe a separate issue would be a good idea (please advise), I would revise it:

go into the next meeting to discuss the two points you state above, but more importantly, to discuss process expectations and team member responsibilities towards that and their peers.

@SMotaal
Copy link

SMotaal commented Mar 27, 2019

@MylesBorins Are we not meeting this week?

@MylesBorins
Copy link
Contributor Author

we are. Making agenda issue right now. Sorry I was so burried I totally spaced that I need to do that 😇

@SMotaal
Copy link

SMotaal commented Mar 27, 2019

No worries — I just worried me be distracted and such 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants