electron 18 uses context aware plugin Napi::Addon. Sometimes Devtools reload for electron will lead to render process crash. Is there any way to locate the problem？

[Candylong]

electron prompt:
Devtools was disconnected from this page........

Console output：
libc++abi: terminating with uncaught exception of type Napi::Error:
Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.

[KevinEady]

Hi @Candylong ,

Is it possible to provide some repository / minimal reproduction of your crash? It is difficult to diagnose why you are receiving a crash without knowing which Node API features / functions you are using.

Thanks, Kevin

[Candylong]

Hi， @KevinEady ，There is a problematic context here，#1224

[mhdawson]

Discussed in the Node-api team meeting, can you provide the updated version of the source you are using?

[Candylong]

hello, @mhdawson ,I used [email protected]

[NickNaso]

Hi @Candylong I think that @mhdawson asked also for the source code that causes the crash. Is it public? Could you report an example?

[Candylong]

Hi, @NickNaso, @mhdawson addon.node uses a third party library called.DLL, which has multiple threads calling back to.node, and then using thread-safe functions, crashes occur in thread-safe functions when loading.node multiple times

Execute in a thread-safe function
auto jscallback = [=](Napi::Env env, Napi::Function jsCallback)
{
Napi::Object videoFrame = Napi::Object::New(env);
videoFrame .Set("width", Napi::Number::New(env, 1920)); //crash happens
}

[mhdawson]

What we were hoping for is a simple recreate, code that we can run to recreate the crash you were seeing. Is that something you can extract/provide?

[Candylong]

@mhdawson , It is in thread-safe functions that an exception is thrown, as shown below, and when a exception occurs, can I use this interface [GetAndClearPendingException] to clear exceptions

[Candylong]

I have arranged my demo and put it here(https://github.com/Candylong/napi-electron-demo). I mainly run it on windows, and it can be reproduced after about 5 operations. Can you have a try

@NickNaso , Hi, I have arranged my demo and put it here(https://github.com/Candylong/napi-electron-demo). I mainly run it on windows, and it can be reproduced after about 5 operations. Can you have a try

[Candylong]

The relevant questions are as follows，#1244

[gabrielschulhof]

I just tried to run your demo. It says "We are using Node.js 18.12.1, Chromium 110.0.5481.208, and Electron 23.2.2.", and it doesn not crash.

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.