Skip to content

Wonderful docs #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmacnaughton opened this issue Dec 28, 2018 · 2 comments
Closed

Wonderful docs #418

bmacnaughton opened this issue Dec 28, 2018 · 2 comments

Comments

@bmacnaughton
Copy link
Contributor

I know you don't need random issues clogging up your workflow. You can just close this without comment. But the improvement this has undergone since I first used Nan about 15 months ago is monumental. Documents like object-lifetime-management provide the concepts that really put the pieces together.

Please thank everyone for their work. Oh yeah, and the c++ node-addon-api rocks too.

@NickNaso
Copy link
Member

Hi @bmacnaughton,
thank you for this wonderful feedback. I'm really happy that you appreciated the documentation. All the N-API team worked hard trying to write something that is more than just a reference and your feedback confirm me that we are in the right direction.
Furthermore we want improve our documentation like reported in the following issue:
#368. Please if you have some ideas or feedback about that feel free to propose them and if you want contribute in any way you are welcome.

@NickNaso
Copy link
Member

NickNaso commented Jan 9, 2019

I'm closing the issue. @bmacnaughton Thanks again for your appreciation.

@NickNaso NickNaso closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants