Skip to content

Commit b0d428d

Browse files
authored
Update README (#34)
1 parent cc90311 commit b0d428d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
[![npm](https://img.shields.io/npm/v/node-core-utils.svg?style=flat-square)](https://npmjs.org/package/node-core-utils)
33
[![Build Status](https://travis-ci.org/joyeecheung/node-core-utils.svg?branch=master)](https://travis-ci.org/joyeecheung/node-core-utils)
44
[![codecov](https://codecov.io/gh/joyeecheung/node-core-utils/branch/master/graph/badge.svg)](https://codecov.io/gh/joyeecheung/node-core-utils)
5+
[![Known Vulnerabilities](https://snyk.io/test/github/joyeecheung/node-core-utils/badge.svg)](https://snyk.io/test/github/joyeecheung/node-core-utils)
56

67
CLI tools for Node.js Core collaborators
78

@@ -10,7 +11,9 @@ CLI tools for Node.js Core collaborators
1011
First, [follow these instructions](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/)
1112
to create a personal access token.
1213

13-
Note: You don't need to check any boxes, these tools only require public access(for now).
14+
Note: We need to read the email of the PR author in order to check if it matches
15+
the email of the commit author. This requires checking the box `user:email` when
16+
you create the personal access token (you can edit the permission later as well).
1417

1518
Then create a file named `.ncurc` under your `$HOME` directory (`~/.ncurc`);
1619

@@ -44,8 +47,7 @@ This one is inspired by Evan Lucas's [node-review](https://github.com/evanlucas/
4447
- [x] Generate `Fixes`
4548
- [x] Generate `Refs`
4649
- [x] Check for CI runs
47-
- [ ] Check if commiters match authors
48-
- Only when `"authorAssociation": "FIRST_TIME_CONTRIBUTOR"`
50+
- [x] Check if commiters match authors
4951
- [x] Check 48-hour wait
5052
- [x] Check two TSC approval for semver-major
5153
- [ ] Warn new commits after reviews

0 commit comments

Comments
 (0)