File tree Expand file tree Collapse file tree 1 file changed +5
-3
lines changed Expand file tree Collapse file tree 1 file changed +5
-3
lines changed Original file line number Diff line number Diff line change 2
2
[ ![ npm] ( https://img.shields.io/npm/v/node-core-utils.svg?style=flat-square )] ( https://npmjs.org/package/node-core-utils )
3
3
[ ![ Build Status] ( https://travis-ci.org/joyeecheung/node-core-utils.svg?branch=master )] ( https://travis-ci.org/joyeecheung/node-core-utils )
4
4
[ ![ codecov] ( https://codecov.io/gh/joyeecheung/node-core-utils/branch/master/graph/badge.svg )] ( https://codecov.io/gh/joyeecheung/node-core-utils )
5
+ [ ![ Known Vulnerabilities] ( https://snyk.io/test/github/joyeecheung/node-core-utils/badge.svg )] ( https://snyk.io/test/github/joyeecheung/node-core-utils )
5
6
6
7
CLI tools for Node.js Core collaborators
7
8
@@ -10,7 +11,9 @@ CLI tools for Node.js Core collaborators
10
11
First, [ follow these instructions] ( https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/ )
11
12
to create a personal access token.
12
13
13
- Note: You don't need to check any boxes, these tools only require public access(for now).
14
+ Note: We need to read the email of the PR author in order to check if it matches
15
+ the email of the commit author. This requires checking the box ` user:email ` when
16
+ you create the personal access token (you can edit the permission later as well).
14
17
15
18
Then create a file named ` .ncurc ` under your ` $HOME ` directory (` ~/.ncurc ` );
16
19
@@ -44,8 +47,7 @@ This one is inspired by Evan Lucas's [node-review](https://github.com/evanlucas/
44
47
- [x] Generate ` Fixes `
45
48
- [x] Generate ` Refs `
46
49
- [x] Check for CI runs
47
- - [ ] Check if commiters match authors
48
- - Only when ` "authorAssociation": "FIRST_TIME_CONTRIBUTOR" `
50
+ - [x] Check if commiters match authors
49
51
- [x] Check 48-hour wait
50
52
- [x] Check two TSC approval for semver-major
51
53
- [ ] Warn new commits after reviews
You can’t perform that action at this time.
0 commit comments