fs.unlink('not_empty_directory', ...) on Windows raises EPERM instead of EISDIR

[mdesantis]

node 0.10.12, Windows 7 64bit

The code:

fs = require('fs');
fs.unlink('./not_empty_directory', function(err) { if(err) throw err });

raises a EPERM error. The documentation says its behaviour is like unlink(2), so I expect it to raise a EISIDIR error.

If on Windows the behaviour is different from Linux/Unix unlink(2) maybe it should be pointed out on the documentation.

[isaacs]

@bnoordhuis @piscisaureus I'm inclined to think that libuv should raise an EISDIR here, but I'd be ok with a doc "fix" if that's too tricky to do. What do you think?

[chrisdickinson]

Per @bnoordhuis in IRC:

<chrisdickinson> bnoordhuis: recently checked out this issue (https://github.com/joyent/node/issues/5791) -- fs raising EPERM on unlink(directory) -- 
seems to still be an issue on osx/windows. do you think it's worth fixing that in libuv, or just doing a doc update?
<bnoordhuis> chrisdickinson: doc update. libuv just passes on the os error

[chrisdickinson]

This should be included in the error documentation PR. Making a note of it there and closing this issue.