Skip to content

deps: v8 will require ICU 63 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srl295 opened this issue Nov 8, 2018 · 3 comments
Closed

deps: v8 will require ICU 63 #86

srl295 opened this issue Nov 8, 2018 · 3 comments
Assignees

Comments

@srl295
Copy link
Member

srl295 commented Nov 8, 2018

When https://crbug.com/v8/8401 lands in Node.js, ICU ≥63 will be required. Looks like v8 may not check the version properly.

see also nodejs/node#24253

Something like the following (not sure of the newline situation)

diff --git a/tools/icu/icu_versions.json b/tools/icu/icu_versions.json
index e17ee8beee..7224e9debe 100644
--- a/tools/icu/icu_versions.json
+++ b/tools/icu/icu_versions.json
@@ -1,3 +1,3 @@
 {
-    "minimum_icu": 57
-}
\ No newline at end of file
+    "minimum_icu": 63
+}
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2018

looks like v8/v8@30a350f

@srl295
Copy link
Member Author

srl295 commented Nov 9, 2018

v8 is tracking this in
https://crbug.com/v8/8424 to make the requirement clear.

@srl295 srl295 assigned srl295 and ryzokuken and unassigned srl295 Nov 9, 2018
@srl295
Copy link
Member Author

srl295 commented Nov 9, 2018

Fixed in
nodejs/node@f4fd7d5 via nodejs/node#24258

@srl295 srl295 closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants