Skip to content

Commit 02f794a

Browse files
sam-githubtargos
authored andcommitted
src: remove memory_tracker-inl.h from header files
Inline headers should only be included into the .cc files that use them. PR-URL: #27755 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 940577b commit 02f794a

23 files changed

+23
-1
lines changed

src/base_object.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
2626

27-
#include "memory_tracker-inl.h"
27+
#include "memory_tracker.h"
2828
#include "v8.h"
2929
#include <type_traits> // std::remove_reference
3030

src/cares_wrap.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "ares.h"
2424
#include "async_wrap-inl.h"
2525
#include "env-inl.h"
26+
#include "memory_tracker-inl.h"
2627
#include "node.h"
2728
#include "req_wrap-inl.h"
2829
#include "util-inl.h"

src/env.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "env.h"
22

33
#include "async_wrap.h"
4+
#include "memory_tracker-inl.h"
45
#include "node_buffer.h"
56
#include "node_context_data.h"
67
#include "node_errors.h"

src/heap_utils.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "env-inl.h"
2+
#include "memory_tracker-inl.h"
23
#include "stream_base-inl.h"
34
#include "util-inl.h"
45

src/inspector_js_api.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "base_object-inl.h"
22
#include "inspector_agent.h"
33
#include "inspector_io.h"
4+
#include "memory_tracker-inl.h"
45
#include "util-inl.h"
56
#include "v8.h"
67
#include "v8-inspector.h"

src/inspector_profiler.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include <sstream>
33
#include "base_object-inl.h"
44
#include "debug_utils.h"
5+
#include "memory_tracker-inl.h"
56
#include "node_file.h"
67
#include "node_internals.h"
78
#include "v8-inspector.h"

src/module_wrap.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "module_wrap.h"
22

33
#include "env.h"
4+
#include "memory_tracker-inl.h"
45
#include "node_errors.h"
56
#include "node_url.h"
67
#include "util-inl.h"

src/node.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#include "debug_utils.h"
2727
#include "env-inl.h"
28+
#include "memory_tracker-inl.h"
2829
#include "node_binding.h"
2930
#include "node_internals.h"
3031
#include "node_main_instance.h"

src/node_config.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "env-inl.h"
2+
#include "memory_tracker.h"
23
#include "node.h"
34
#include "node_i18n.h"
45
#include "node_native_module_env.h"

src/node_contextify.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
#include "node_contextify.h"
2323

24+
#include "memory_tracker-inl.h"
2425
#include "node_internals.h"
2526
#include "node_watchdog.h"
2627
#include "base_object-inl.h"

src/node_crypto.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
#include "async_wrap-inl.h"
3333
#include "base_object-inl.h"
3434
#include "env-inl.h"
35+
#include "memory_tracker-inl.h"
3536
#include "string_bytes.h"
3637
#include "threadpoolwork-inl.h"
3738
#include "util-inl.h"

src/node_crypto_bio.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
#include "base_object-inl.h"
23+
#include "memory_tracker-inl.h"
2324
#include "node_crypto_bio.h"
2425
#include "openssl/bio.h"
2526
#include "util-inl.h"

src/node_file.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
#include "node_file.h"
2323
#include "aliased_buffer.h"
24+
#include "memory_tracker-inl.h"
2425
#include "node_buffer.h"
2526
#include "node_process.h"
2627
#include "node_stat_watcher.h"

src/node_http2.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "aliased_buffer.h"
22
#include "debug_utils.h"
3+
#include "memory_tracker-inl.h"
34
#include "node.h"
45
#include "node_buffer.h"
56
#include "node_http2.h"

src/node_http_parser_llhttp.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#define NODE_EXPERIMENTAL_HTTP 1
22

33
#include "node_http_parser_impl.h"
4+
#include "memory_tracker-inl.h"
45
#include "node_metadata.h"
56
#include "util-inl.h"
67

src/node_http_parser_traditional.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#undef NODE_EXPERIMENTAL_HTTP
33
#endif
44

5+
#include "memory_tracker-inl.h"
56
#include "node_http_parser_impl.h"
67
#include "node_metadata.h"
78
#include "util-inl.h"

src/node_messaging.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
#include "async_wrap-inl.h"
44
#include "debug_utils.h"
5+
#include "memory_tracker-inl.h"
56
#include "node_contextify.h"
67
#include "node_buffer.h"
78
#include "node_errors.h"

src/node_perf.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "aliased_buffer.h"
2+
#include "memory_tracker-inl.h"
23
#include "node_internals.h"
34
#include "node_perf.h"
45
#include "node_buffer.h"

src/node_stat_watcher.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

22+
#include "memory_tracker-inl.h"
2223
#include "node_stat_watcher.h"
2324
#include "async_wrap-inl.h"
2425
#include "env.h"

src/node_trace_events.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "base_object-inl.h"
22
#include "env.h"
3+
#include "memory_tracker-inl.h"
34
#include "node.h"
45
#include "node_internals.h"
56
#include "node_v8_platform-inl.h"

src/node_worker.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "node_worker.h"
22
#include "debug_utils.h"
3+
#include "memory_tracker-inl.h"
34
#include "node_errors.h"
45
#include "node_buffer.h"
56
#include "node_options-inl.h"

src/node_zlib.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

22+
#include "memory_tracker-inl.h"
2223
#include "node.h"
2324
#include "node_buffer.h"
2425

src/tls_wrap.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "tls_wrap.h"
2323
#include "async_wrap-inl.h"
2424
#include "debug_utils.h"
25+
#include "memory_tracker-inl.h"
2526
#include "node_buffer.h" // Buffer
2627
#include "node_crypto.h" // SecureContext
2728
#include "node_crypto_bio.h" // NodeBIO

0 commit comments

Comments
 (0)