Skip to content

Commit 088bba3

Browse files
committed
Revert "src, tools: add debug symbols for node internals"
This reverts commit 446c1ec. Reverted for breaking `make test-v8`. The "find all relevant system headers" logic in `tools/gen-postmortem-metadata.py` needs more work. Also reverts commit e46c3f7. ("tools: fix typo in gen-postmortem-metadata.py".) PR-URL: #17272 Refs: #14901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent bd0e36d commit 088bba3

File tree

2 files changed

+1
-225
lines changed

2 files changed

+1
-225
lines changed

node.gyp

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@
178178

179179
'dependencies': [
180180
'node_js2c#host',
181-
'deps/nghttp2/nghttp2.gyp:nghttp2'
182181
],
183182

184183
'includes': [
@@ -299,7 +298,6 @@
299298
# node.gyp is added to the project by default.
300299
'common.gypi',
301300
'<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc',
302-
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
303301
],
304302

305303
'variables': {
@@ -972,29 +970,7 @@
972970
}]]
973971
}],
974972
]
975-
},
976-
{
977-
'target_name': 'node_postmortem_metadata',
978-
'type': 'none',
979-
'toolsets': ['host'],
980-
'actions': [
981-
{
982-
'action_name': 'gen-postmortem-metadata',
983-
'process_outputs_as_sources': 1,
984-
'inputs': [
985-
'./tools/gen-postmortem-metadata.py',
986-
],
987-
'outputs': [
988-
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
989-
],
990-
'action': [
991-
'python',
992-
'./tools/gen-postmortem-metadata.py',
993-
'<@(_outputs)',
994-
]
995-
}
996-
]
997-
},
973+
}
998974
], # end targets
999975

1000976
'conditions': [

tools/gen-postmortem-metadata.py

Lines changed: 0 additions & 200 deletions
This file was deleted.

0 commit comments

Comments
 (0)