Skip to content

Commit 0d69ce3

Browse files
richardlaumarco-ippolito
authored andcommitted
test: extend env for test-node-output-errors
Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run. PR-URL: #53535 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
1 parent 0354584 commit 0d69ce3

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

test/parallel/test-node-output-errors.mjs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import { describe, it } from 'node:test';
66
import { pathToFileURL } from 'node:url';
77

88
const skipForceColors =
9-
process.config.variables.icu_gyp_path !== 'tools/icu/icu-generic.gyp' ||
10-
process.config.variables.node_shared_openssl ||
119
(common.isWindows && (Number(os.release().split('.')[0]) !== 10 || Number(os.release().split('.')[2]) < 14393)); // See https://github.com/nodejs/node/pull/33132
1210

1311

@@ -76,7 +74,7 @@ describe('errors output', { concurrency: true }, () => {
7674
];
7775
for (const { name, transform = defaultTransform, env, skip = false } of tests) {
7876
it(name, { skip }, async () => {
79-
await snapshot.spawnAndAssert(fixtures.path(name), transform, { env });
77+
await snapshot.spawnAndAssert(fixtures.path(name), transform, { env: { ...env, ...process.env } });
8078
});
8179
}
8280
});

0 commit comments

Comments
 (0)