Keep 'em IPv6 fixes coming...

Author: treysis

test/parallel/test-http2-connect-options.js

@@ -12,7 +12,7 @@ const assert = require('assert');
 
 const server = http2.createServer((req, res) => {
   console.log(`Connect from: ${req.connection.remoteAddress}`);
-  assert.strictEqual(req.connection.remoteAddress, 'localhost');
+  assert.match(req.connection.remoteAddress, /^(127\.0\.0\.1|::1)$/);
 
   req.on('end', common.mustCall(() => {
     res.writeHead(200, { 'Content-Type': 'text/plain' });
@@ -22,10 +22,10 @@ const server = http2.createServer((req, res) => {
 });
 
 server.listen(0, 'localhost', common.mustCall(() => {
-  const options = { localAddress: 'localhost' };
+  const options = { localAddress: '::1' };
 
   const client = http2.connect(
-    'http://[::1]:' + server.address().port,
+    'http://localhost:' + server.address().port,
     options
   );
   const req = client.request({

test/parallel/test-inspector-wait-for-connection.js

@@ -7,7 +7,8 @@ const assert = require('assert');
 const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
-  const child = new NodeInstance(['-e', `(${main.toString()})()`], '', '');
+  const child = new NodeInstance(['--incpsect=localhost',
+                                  '-e', `(${main.toString()})()`], '', '');
   const session = await child.connectInspectorSession();
   await session.send({ method: 'Runtime.enable' });
   // Check that there is only one console message received.

test/parallel/test-net-dns-lookup.js

@@ -33,7 +33,7 @@ server.listen(0, 'localhost', common.mustCall(function() {
   net.connect(this.address().port, 'localhost')
     .on('lookup', common.mustCall(function(err, ip, type, host) {
       assert.strictEqual(err, null);
-      assert.match(e.address, /^127\.0\.0\.1$|^::1$/); // eslint-disable-line
+      assert.match(ip, /^127\.0\.0\.1$|^::1$/); // eslint-disable-line
       assert.strictEqual(type, 4);
       assert.strictEqual(host, 'localhost');
     }));

test/parallel/test-net-remote-address-port.js

@@ -29,6 +29,7 @@ let conns_closed = 0;
 
 const remoteAddrCandidates = [ common.localhostIPv4 ];
 if (common.hasIPv6) remoteAddrCandidates.push('::ffff:127.0.0.1');
+if (common.hasIPv6) remoteAddrCandidates.push('::1');
 
 const remoteFamilyCandidates = ['IPv4'];
 if (common.hasIPv6) remoteFamilyCandidates.push('IPv6');

test/parallel/test-tcp-wrap-listen.js

@@ -14,7 +14,7 @@ const {
 
 const server = new TCP(TCPConstants.SOCKET);
 
-const r = server.bind('::1', 0);
+const r = server.bind('::', 0);
 assert.strictEqual(r, 0);
 let port = {};
 server.getsockname(port);

test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js

@@ -28,7 +28,7 @@ const server = net.createServer(function onClient(client) {
   }
 });
 
-server.listen(0, common.localhostIPv4, common.mustCall(() => {
+server.listen(0, 'localhost', common.mustCall(() => {
   const countdown = new Countdown(2, () => server.close());
 
   {

test/parallel/test-tls-client-mindhsize.js

@@ -34,7 +34,7 @@ function test(size, err, next) {
     if (next) next();
   });
 
-  server.listen(0, '127.0.0.1', function() {
+  server.listen(0, 'localhost', function() {
     // Client set minimum DH parameter size to 2048 bits so that
     // it fails when it make a connection to the tls server where
     // dhparams is 1024 bits

test/sequential/test-inspector-debug-brk-flag.js

@@ -27,7 +27,8 @@ async function testBreakpointOnStart(session) {
 }
 
 async function runTests() {
-  const child = new NodeInstance(['--inspect', '--inspect-brk']);
+  const child = new NodeInstance(['--inspect=localhost',
+                                  '--inspect-brk=localhost']);
   const session = await child.connectInspectorSession();
 
   await testBreakpointOnStart(session);