src: use node:moduleName as builtin module filename

This change allows for easier recognition of builtin modules in stack
traces.

Refs: #11893

PR-URL: #35498
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>

Author: targos

lib/assert.js

@@ -30,6 +30,8 @@ const {
   NumberIsNaN,
   RegExpPrototypeTest,
   String,
+  StringPrototypeSlice,
+  StringPrototypeStartsWith,
 } = primordials;
 
 const { Buffer } = require('buffer');
@@ -289,8 +291,8 @@ function getErrMessage(message, fn) {
     identifier = `${filename}${line}${column}`;
 
     // Skip Node.js modules!
-    if (filename.endsWith('.js') &&
-        NativeModule.exists(filename.slice(0, -3))) {
+    if (StringPrototypeStartsWith(filename, 'node:') &&
+        NativeModule.exists(StringPrototypeSlice(filename, 5))) {
       errorCache.set(identifier, undefined);
       return;
     }

lib/internal/util/inspect.js

@@ -183,7 +183,7 @@ const strEscapeSequencesReplacerSingle = /[\x00-\x1f\x5c\x7f-\x9f]/g;
 const keyStrRegExp = /^[a-zA-Z_][a-zA-Z_0-9]*$/;
 const numberRegExp = /^(0|[1-9][0-9]*)$/;
 
-const coreModuleRegExp = /^    at (?:[^/\\(]+ \(|)((?<![/\\]).+)\.js:\d+:\d+\)?$/;
+const coreModuleRegExp = /^    at (?:[^/\\(]+ \(|)node:(.+):\d+:\d+\)?$/;
 const nodeModulesRegExp = /[/\\]node_modules[/\\](.+?)(?=[/\\])/g;
 
 const classRegExp = /^(\s+[^(]*?)\s*{/;

src/node_native_module.cc

@@ -260,7 +260,7 @@ MaybeLocal<Function> NativeModuleLoader::LookupAndCompile(
     return {};
   }
 
-  std::string filename_s = id + std::string(".js");
+  std::string filename_s = std::string("node:") + id;
   Local<String> filename =
       OneByteString(isolate, filename_s.c_str(), filename_s.size());
   Local<Integer> line_offset = Integer::New(isolate, 0);

test/message/assert_throws_stack.out

@@ -1,4 +1,4 @@
-assert.js:*
+node:assert:*
       throw err;
       ^
 
@@ -20,8 +20,8 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
   code: 'ERR_ASSERTION',
   actual: Error: foo
       at assert.throws.bar (*assert_throws_stack.js:*)
-      at getActual (assert.js:*)
-      at Function.throws (assert.js:*)
+      at getActual (node:assert:*)
+      at Function.throws (node:assert:*)
       at Object.<anonymous> (*assert_throws_stack.js:*:*)
       at *
       at *

test/message/async_error_nexttick_main.out

@@ -1,7 +1,7 @@
 Error: test
     at one (*fixtures*async-error.js:4:9)
     at two (*fixtures*async-error.js:17:9)
-    at processTicksAndRejections (internal/process/task_queues.js:*:*)
+    at processTicksAndRejections (node:internal/process/task_queues:*:*)
     at async three (*fixtures*async-error.js:20:3)
     at async four (*fixtures*async-error.js:24:3)
     at async main (*message*async_error_nexttick_main.js:7:5)

test/message/core_line_numbers.out

@@ -1,14 +1,14 @@
-punycode.js:42
+node:punycode:42
 	throw new RangeError(errors[type]);
 	^
 
 RangeError: Invalid input
-    at error (punycode.js:42:8)
-    at Object.decode (punycode.js:*:*)
+    at error (node:punycode:42:8)
+    at Object.decode (node:punycode:*:*)
     at Object.<anonymous> (*test*message*core_line_numbers.js:*:*)
-    at Module._compile (internal/modules/cjs/loader.js:*:*)
-    at Object.Module._extensions..js (internal/modules/cjs/loader.js:*:*)
-    at Module.load (internal/modules/cjs/loader.js:*:*)
-    at Function.Module._load (internal/modules/cjs/loader.js:*:*)
-    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:*:*)
-    at internal/main/run_main_module.js:*:*
+    at Module._compile (node:internal/modules/cjs/loader:*:*)
+    at Object.Module._extensions..js (node:internal/modules/cjs/loader:*:*)
+    at Module.load (node:internal/modules/cjs/loader:*:*)
+    at Function.Module._load (node:internal/modules/cjs/loader:*:*)
+    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
+    at node:internal/main/run_main_module:*:*

test/message/error_exit.out

@@ -1,5 +1,5 @@
 Exiting with code=1
-assert.js:*
+node:assert:*
   throw new AssertionError(obj);
   ^
 
@@ -8,12 +8,12 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
 1 !== 2
 
     at Object.<anonymous> (*test*message*error_exit.js:*:*)
-    at Module._compile (internal/modules/cjs/loader.js:*:*)
-    at Object.Module._extensions..js (internal/modules/cjs/loader.js:*:*)
-    at Module.load (internal/modules/cjs/loader.js:*:*)
-    at Function.Module._load (internal/modules/cjs/loader.js:*:*)
-    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:*:*)
-    at internal/main/run_main_module.js:*:* {
+    at Module._compile (node:internal/modules/cjs/loader:*:*)
+    at Object.Module._extensions..js (node:internal/modules/cjs/loader:*:*)
+    at Module.load (node:internal/modules/cjs/loader:*:*)
+    at Function.Module._load (node:internal/modules/cjs/loader:*:*)
+    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
+    at node:internal/main/run_main_module:*:* {
   generatedMessage: true,
   code: 'ERR_ASSERTION',
   actual: 1,

test/message/error_with_nul.out

@@ -3,5 +3,5 @@ await async () => 0;
 ^^^^^
 
 SyntaxError: Unexpected reserved word
-    at Loader.moduleStrategy (internal/modules/esm/translators.js:*:*)
-    at async link (internal/modules/esm/module_job.js:*:*)
+    at Loader.moduleStrategy (node:internal/modules/esm/translators:*:*)
+    at async link (node:internal/modules/esm/module_job:*:*)

test/message/esm_display_syntax_error.out

@@ -2,7 +2,7 @@ file:///*/test/message/esm_display_syntax_error_import.mjs:5
   notfound
   ^^^^^^^^
 SyntaxError: The requested module '../fixtures/es-module-loaders/module-named-exports.mjs' does not provide an export named 'notfound'
-    at ModuleJob._instantiate (internal/modules/esm/module_job.js:*:*)
-    at async ModuleJob.run (internal/modules/esm/module_job.js:*:*)
-    at async Loader.import (internal/modules/esm/loader.js:*:*)
-    at async Object.loadESM (internal/process/esm_loader.js:*:*)
+    at ModuleJob._instantiate (node:internal/modules/esm/module_job:*:*)
+    at async ModuleJob.run (node:internal/modules/esm/module_job:*:*)
+    at async Loader.import (node:internal/modules/esm/loader:*:*)
+    at async Object.loadESM (node:internal/process/esm_loader:*:*)