Skip to content

Commit 266c1f4

Browse files
kenny-yGabriel Schulhof
authored and
Gabriel Schulhof
committed
build: add new benchmark targets
Adding new build targets: 'bench-addons' & 'bench-addons-clean'. With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking. PR-URL: #20905 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent fe67287 commit 266c1f4

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

Makefile

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ clean: ## Remove build artifacts.
141141
$(RM) -r test/tmp*
142142
$(RM) -r test/.tmp*
143143
$(MAKE) test-addons-clean
144+
$(MAKE) bench-addons-clean
144145

145146
.PHONY: distclean
146147
distclean:
@@ -1047,13 +1048,23 @@ ifeq ($(XZ), 0)
10471048
endif
10481049

10491050
.PHONY: bench-all
1050-
bench-all:
1051+
bench-all: bench-addons-build
10511052
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."
10521053

10531054
.PHONY: bench
1054-
bench:
1055+
bench: bench-addons-build
10551056
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."
10561057

1058+
# Build required addons for benchmark before running it.
1059+
.PHONY: bench-addons-build
1060+
bench-addons-build: benchmark/napi/function_call/build/Release/binding.node \
1061+
benchmark/napi/function_args/build/Release/binding.node
1062+
1063+
.PHONY: bench-addons-clean
1064+
bench-addons-clean:
1065+
$(RM) -r benchmark/napi/function_call/build
1066+
$(RM) -r benchmark/napi/function_args/build
1067+
10571068
.PHONY: lint-md-clean
10581069
lint-md-clean:
10591070
$(RM) -r tools/remark-cli/node_modules

0 commit comments

Comments
 (0)