lib: don't match sourceMappingURL in strings

Prior to this change `sourceMappingURL` in string where being matched
by the RegExp which caused sourcemaps not be loaded when using the
`--enable-source-maps` flag. This commit changes the RegExp to match
the last occurrence.

Fixes: #44654
PR-URL: #44658
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

Author: alan-agius4

lib/internal/source_map/source_map_cache.js

@@ -41,8 +41,8 @@ const esmSourceMapCache = new SafeMap();
 // The generated sources is not mutable, so we can use a Map without memory concerns:
 const generatedSourceMapCache = new SafeMap();
 const kLeadingProtocol = /^\w+:\/\//;
-const kSourceMappingURLMagicComment = /\/[*/]#\s+sourceMappingURL=(?<sourceMappingURL>[^\s]+)/;
-const kSourceURLMagicComment = /\/[*/]#\s+sourceURL=(?<sourceURL>[^\s]+)/;
+const kSourceMappingURLMagicComment = /\/[*/]#\s+sourceMappingURL=(?<sourceMappingURL>[^\s]+)/g;
+const kSourceURLMagicComment = /\/[*/]#\s+sourceURL=(?<sourceURL>[^\s]+)/g;
 
 const { fileURLToPath, pathToFileURL, URL } = require('internal/url');
 let SourceMap;
@@ -80,11 +80,14 @@ function setSourceMapsEnabled(val) {
 }
 
 function extractSourceURLMagicComment(content) {
-  const matchSourceURL = RegExpPrototypeExec(
-    kSourceURLMagicComment,
-    content
-  );
-  if (matchSourceURL === null) {
+  let match;
+  let matchSourceURL;
+  // A while loop is used here to get the last occurrence of sourceURL.
+  // This is needed so that we don't match sourceURL in string literals.
+  while ((match = RegExpPrototypeExec(kSourceURLMagicComment, content))) {
+    matchSourceURL = match;
+  }
+  if (matchSourceURL == null) {
     return null;
   }
   let sourceURL = matchSourceURL.groups.sourceURL;
@@ -104,13 +107,21 @@ function maybeCacheSourceMap(filename, content, cjsModuleInstance, isGeneratedSo
     debug(err);
     return;
   }
-  const match = RegExpPrototypeExec(kSourceMappingURLMagicComment, content);
+
+  let match;
+  let lastMatch;
+  // A while loop is used here to get the last occurrence of sourceMappingURL.
+  // This is needed so that we don't match sourceMappingURL in string literals.
+  while ((match = RegExpPrototypeExec(kSourceMappingURLMagicComment, content))) {
+    lastMatch = match;
+  }
+
   if (sourceURL === undefined) {
     sourceURL = extractSourceURLMagicComment(content);
   }
-  if (match) {
-    const data = dataFromUrl(filename, match.groups.sourceMappingURL);
-    const url = data ? null : match.groups.sourceMappingURL;
+  if (lastMatch) {
+    const data = dataFromUrl(filename, lastMatch.groups.sourceMappingURL);
+    const url = data ? null : lastMatch.groups.sourceMappingURL;
     if (cjsModuleInstance) {
       cjsSourceMapCache.set(cjsModuleInstance, {
         filename,

test/fixtures/source-map/typescript-sourcemapping_url_string.js

@@ -0,0 +1,13 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../common');
+Error.stackTraceLimit = 2;
+
+try {
+  require('../fixtures/source-map/typescript-sourcemapping_url_string');
+} catch (err) {
+  setTimeout(() => {
+    console.info(err);
+  }, 10);
+}

test/fixtures/source-map/typescript-sourcemapping_url_string.js.map

@@ -0,0 +1,3 @@
+Error: an exception.
+    at *typescript-sourcemapping_url_string.ts:3:7*
+    at Module._compile (node:internal/modules/cjs/loader:*)