Skip to content

Commit 2abdcbb

Browse files
targosMylesBorins
authored andcommitted
deps: V8: cherry-pick f2d92ec
Original commit message: [base] Add missing include of <type_traits> The missing include causes compilation failures for node.js, see #30020. It's not great to have includes in a file called "macros.h", but we define several functions there that make use of type traits. Fixing that is a separate project. [email protected] Change-Id: Idb067679e597521230f94eb8c99f1347ed3808cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868622 Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#64386} Refs: v8/v8@f2d92ec Backport-PR-URL: #30513 PR-URL: #30020 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 4638361 commit 2abdcbb

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.8',
42+
'v8_embedder_string': '-node.9',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/src/base/macros.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#define V8_BASE_MACROS_H_
77

88
#include <limits>
9+
#include <type_traits>
910

1011
#include "src/base/compiler-specific.h"
1112
#include "src/base/logging.h"

0 commit comments

Comments
 (0)