File tree 1 file changed +6
-4
lines changed 1 file changed +6
-4
lines changed Original file line number Diff line number Diff line change @@ -128,10 +128,12 @@ onboarding session.
128
128
* One ` LGTM ` is sufficient, except for semver-major changes.
129
129
* More than one is better.
130
130
* Breaking changes must be LGTM'ed by at least two CTC members.
131
- * If one or more Collaborators object to a change, it may not land. Your options in such a situation (aside from abandoning the change) are:
132
- * Engage those with objections to persuade them to drop their objections.
133
- * Alter your changes so that the objections are dropped.
134
- * Escalate to the CTC with the ` ctc-agenda ` label. Do not do this without exhausting the other options first.
131
+ * If one or more Collaborators object to a change, it should not land until
132
+ the objection is addressed. The options for such a situation include:
133
+ * Engaging those with objections to determine a viable path forward;
134
+ * Altering the pull request to address the objections;
135
+ * Escalating the discussion to the CTC using the ` ctc-agenda ` label.
136
+ This should only be done after other options have been exhausted.
135
137
136
138
* Wait before merging non-trivial changes.
137
139
* 48 hours during the week and 72 hours on weekends.
You can’t perform that action at this time.
0 commit comments