Skip to content

Commit 2f5bfe3

Browse files
committed
squash: rewording
1 parent 8a98226 commit 2f5bfe3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

doc/onboarding.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,12 @@ onboarding session.
128128
* One `LGTM` is sufficient, except for semver-major changes.
129129
* More than one is better.
130130
* Breaking changes must be LGTM'ed by at least two CTC members.
131-
* If one or more Collaborators object to a change, it may not land. Your options in such a situation (aside from abandoning the change) are:
132-
* Engage those with objections to persuade them to drop their objections.
133-
* Alter your changes so that the objections are dropped.
134-
* Escalate to the CTC with the `ctc-agenda` label. Do not do this without exhausting the other options first.
131+
* If one or more Collaborators object to a change, it should not land until
132+
the objection is addressed. The options for such a situation include:
133+
* Engaging those with objections to determine a viable path forward;
134+
* Altering the pull request to address the objections;
135+
* Escalating the discussion to the CTC using the `ctc-agenda` label.
136+
This should only be done after other options have been exhausted.
135137

136138
* Wait before merging non-trivial changes.
137139
* 48 hours during the week and 72 hours on weekends.

0 commit comments

Comments
 (0)