Skip to content

Commit 329e625

Browse files
committed
src: fixup linting after rebase/updates
1 parent 97a082d commit 329e625

File tree

4 files changed

+5
-20
lines changed

4 files changed

+5
-20
lines changed

src/crypto/crypto_ec.cc

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -965,26 +965,11 @@ KeyObjectData ImportJWKEcKey(Environment* env,
965965
return KeyObjectData::CreateAsymmetric(type, std::move(pkey));
966966
}
967967

968-
<<<<<<< HEAD
969-
Maybe<bool> GetEcKeyDetail(Environment* env,
968+
Maybe<void> GetEcKeyDetail(Environment* env,
970969
const KeyObjectData& key,
971970
Local<Object> target) {
972971
Mutex::ScopedLock lock(key.mutex());
973972
const auto& m_pkey = key.GetAsymmetricKey();
974-
||||||| parent of 6b5b11a52a (src: convert more uses of Maybe<bool> to Maybe<void>)
975-
Maybe<bool> GetEcKeyDetail(
976-
Environment* env,
977-
std::shared_ptr<KeyObjectData> key,
978-
Local<Object> target) {
979-
ManagedEVPPKey m_pkey = key->GetAsymmetricKey();
980-
Mutex::ScopedLock lock(*m_pkey.mutex());
981-
=======
982-
Maybe<void> GetEcKeyDetail(Environment* env,
983-
std::shared_ptr<KeyObjectData> key,
984-
Local<Object> target) {
985-
ManagedEVPPKey m_pkey = key->GetAsymmetricKey();
986-
Mutex::ScopedLock lock(*m_pkey.mutex());
987-
>>>>>>> 6b5b11a52a (src: convert more uses of Maybe<bool> to Maybe<void>)
988973
CHECK_EQ(EVP_PKEY_id(m_pkey.get()), EVP_PKEY_EC);
989974

990975
const EC_KEY* ec = EVP_PKEY_get0_EC_KEY(m_pkey.get());

src/crypto/crypto_keygen.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ KeyGenJobStatus SecretKeyGenTraits::DoKeyGen(Environment* env,
8080
}
8181

8282
MaybeLocal<Value> SecretKeyGenTraits::EncodeKey(Environment* env,
83-
SecretKeyGenConfig* params) {
83+
SecretKeyGenConfig* params) {
8484
auto data = KeyObjectData::CreateSecret(std::move(params->out));
8585
Local<Value> ret;
8686
if (!KeyObjectHandle::Create(env, data).ToLocal(&ret)) {

src/crypto/crypto_keys.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ Maybe<void> GetSecretKeyDetail(Environment* env,
521521
Local<Object> target) {
522522
// For the secret key detail, all we care about is the length,
523523
// converted to bits.
524-
size_t length = key->GetSymmetricKeySize() * CHAR_BIT;
524+
size_t length = key.GetSymmetricKeySize() * CHAR_BIT;
525525
if (target
526526
->Set(env->context(),
527527
env->length_string(),

src/crypto/crypto_sig.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -648,11 +648,11 @@ Maybe<void> SignTraits::AdditionalConfig(
648648
if (params->mode == SignConfiguration::kVerify) {
649649
auto data =
650650
KeyObjectData::GetPublicOrPrivateKeyFromJs(args, &keyParamOffset);
651-
if (!data) return Nothing<bool>();
651+
if (!data) return Nothing<void>();
652652
params->key = std::move(data);
653653
} else {
654654
auto data = KeyObjectData::GetPrivateKeyFromJs(args, &keyParamOffset, true);
655-
if (!data) return Nothing<bool>();
655+
if (!data) return Nothing<void>();
656656
params->key = std::move(data);
657657
}
658658

0 commit comments

Comments
 (0)