worker: add test for env option when using process-only cli flag

nicolo-ribaudo · nicolo-ribaudo · commit 36c2349cf182 · 2024-05-16T11:55:46.000+02:00
It should be possible to pass the `env` option to a worker
even when the parent process is using a process-level flag, such
as `--title` or a V8-specific flag.

This test is currently failing in Node.js 22.2.0
diff --git a/deps/_bad_scm/v8/buildn59_f3j2/build b/deps/_bad_scm/v8/buildn59_f3j2/build
@@ -0,0 +1 @@
+Subproject commit 4c678ca2630e871ee5e975f6fe84542c3701417f
diff --git a/deps/_bad_scm/v8/buildta_v5pcc/build b/deps/_bad_scm/v8/buildta_v5pcc/build
@@ -0,0 +1 @@
+Subproject commit 4c678ca2630e871ee5e975f6fe84542c3701417f
diff --git a/deps/_bad_scm/v8/buildtools44d5o6ee/buildtools b/deps/_bad_scm/v8/buildtools44d5o6ee/buildtools
@@ -0,0 +1 @@
+Subproject commit ca4997ede874d6caaf5393a2d6d503b68d5d39dc
diff --git a/deps/_bad_scm/v8/buildtools571ly3aq/buildtools b/deps/_bad_scm/v8/buildtools571ly3aq/buildtools
@@ -0,0 +1 @@
+Subproject commit ca4997ede874d6caaf5393a2d6d503b68d5d39dc
diff --git a/deps/_bad_scm/v8/buildtools7o_1f8h9/buildtools b/deps/_bad_scm/v8/buildtools7o_1f8h9/buildtools
@@ -0,0 +1 @@
+Subproject commit ca4997ede874d6caaf5393a2d6d503b68d5d39dc
diff --git a/deps/_bad_scm/v8/buildtoolsl665tqes/buildtools b/deps/_bad_scm/v8/buildtoolsl665tqes/buildtools
@@ -0,0 +1 @@
+Subproject commit ca4997ede874d6caaf5393a2d6d503b68d5d39dc
diff --git a/deps/_bad_scm/v8/buildw4vyl2bp/build b/deps/_bad_scm/v8/buildw4vyl2bp/build
@@ -0,0 +1 @@
+Subproject commit 4c678ca2630e871ee5e975f6fe84542c3701417f
diff --git a/deps/_bad_scm/v8/third_party/depot_tools5gilq51n/depot_tools b/deps/_bad_scm/v8/third_party/depot_tools5gilq51n/depot_tools
@@ -0,0 +1 @@
+Subproject commit 6551a7eb433575243c5212bd2be9ef0930e2dcca
diff --git a/deps/_bad_scm/v8/third_party/depot_toolsq1jq6a9j/depot_tools b/deps/_bad_scm/v8/third_party/depot_toolsq1jq6a9j/depot_tools
@@ -0,0 +1 @@
+Subproject commit 6551a7eb433575243c5212bd2be9ef0930e2dcca
diff --git a/deps/_bad_scm/v8/third_party/depot_toolstbmjmtb7/depot_tools b/deps/_bad_scm/v8/third_party/depot_toolstbmjmtb7/depot_tools
@@ -0,0 +1 @@
+Subproject commit 6551a7eb433575243c5212bd2be9ef0930e2dcca
diff --git a/deps/_bad_scm/v8/third_party/google_benchmark/src5b680z1w/src b/deps/_bad_scm/v8/third_party/google_benchmark/src5b680z1w/src
@@ -0,0 +1 @@
+Subproject commit d5c55e8c42a8782cb24f6011d0e88449237ab842
diff --git a/deps/_bad_scm/v8/third_party/google_benchmark/srcdesheglk/src b/deps/_bad_scm/v8/third_party/google_benchmark/srcdesheglk/src
@@ -0,0 +1 @@
+Subproject commit d5c55e8c42a8782cb24f6011d0e88449237ab842
diff --git a/deps/_bad_scm/v8/third_party/google_benchmark/srckzj4rumj/src b/deps/_bad_scm/v8/third_party/google_benchmark/srckzj4rumj/src
@@ -0,0 +1 @@
+Subproject commit d5c55e8c42a8782cb24f6011d0e88449237ab842
diff --git a/deps/_bad_scm/v8/third_party/google_benchmark/srcmnqd6gig/src b/deps/_bad_scm/v8/third_party/google_benchmark/srcmnqd6gig/src
@@ -0,0 +1 @@
+Subproject commit d5c55e8c42a8782cb24f6011d0e88449237ab842
diff --git a/deps/_bad_scm/v8/third_party/googletest/srcdgv9sahc/src b/deps/_bad_scm/v8/third_party/googletest/srcdgv9sahc/src
@@ -0,0 +1 @@
+Subproject commit eff443c6ef5eb6ab598bfaae27f9427fdb4f6af7
diff --git a/deps/_bad_scm/v8/third_party/googletest/srclw0sbse7/src b/deps/_bad_scm/v8/third_party/googletest/srclw0sbse7/src
@@ -0,0 +1 @@
+Subproject commit eff443c6ef5eb6ab598bfaae27f9427fdb4f6af7
diff --git a/deps/_bad_scm/v8/third_party/googletest/srcswd9gd_x/src b/deps/_bad_scm/v8/third_party/googletest/srcswd9gd_x/src
@@ -0,0 +1 @@
+Subproject commit eff443c6ef5eb6ab598bfaae27f9427fdb4f6af7
diff --git a/deps/_bad_scm/v8/third_party/googletest/srctft4g3sl/src b/deps/_bad_scm/v8/third_party/googletest/srctft4g3sl/src
@@ -0,0 +1 @@
+Subproject commit eff443c6ef5eb6ab598bfaae27f9427fdb4f6af7
diff --git a/deps/_bad_scm/v8/third_party/googletest/srculfv7k58/src b/deps/_bad_scm/v8/third_party/googletest/srculfv7k58/src
@@ -0,0 +1 @@
+Subproject commit eff443c6ef5eb6ab598bfaae27f9427fdb4f6af7
diff --git a/deps/_bad_scm/v8/third_party/icu78k2a_jd/icu b/deps/_bad_scm/v8/third_party/icu78k2a_jd/icu
@@ -0,0 +1 @@
+Subproject commit 5ae60ba128b3d593307a221dc9322e83b0e9647f
diff --git a/deps/_bad_scm/v8/third_party/icubh6htw31/icu b/deps/_bad_scm/v8/third_party/icubh6htw31/icu
@@ -0,0 +1 @@
+Subproject commit 5ae60ba128b3d593307a221dc9322e83b0e9647f
diff --git a/deps/_bad_scm/v8/third_party/icuc7gtl8b7/icu b/deps/_bad_scm/v8/third_party/icuc7gtl8b7/icu
@@ -0,0 +1 @@
+Subproject commit 5ae60ba128b3d593307a221dc9322e83b0e9647f
diff --git a/deps/_bad_scm/v8/third_party/jinja26ok7tl82/jinja2 b/deps/_bad_scm/v8/third_party/jinja26ok7tl82/jinja2
@@ -0,0 +1 @@
+Subproject commit c9c77525ea20c871a1d4658f8d312b51266d4bad
diff --git a/deps/_bad_scm/v8/third_party/jinja2je7kxrdd/jinja2 b/deps/_bad_scm/v8/third_party/jinja2je7kxrdd/jinja2
@@ -0,0 +1 @@
+Subproject commit c9c77525ea20c871a1d4658f8d312b51266d4bad
diff --git a/deps/_bad_scm/v8/third_party/jinja2vkmufmmh/jinja2 b/deps/_bad_scm/v8/third_party/jinja2vkmufmmh/jinja2
@@ -0,0 +1 @@
+Subproject commit c9c77525ea20c871a1d4658f8d312b51266d4bad
diff --git a/deps/_bad_scm/v8/third_party/jinja2zl1o5ii0/jinja2 b/deps/_bad_scm/v8/third_party/jinja2zl1o5ii0/jinja2
@@ -0,0 +1 @@
+Subproject commit c9c77525ea20c871a1d4658f8d312b51266d4bad
diff --git a/deps/_bad_scm/v8/third_party/jinja2zpgv_b6m/jinja2 b/deps/_bad_scm/v8/third_party/jinja2zpgv_b6m/jinja2
@@ -0,0 +1 @@
+Subproject commit c9c77525ea20c871a1d4658f8d312b51266d4bad
diff --git a/deps/_bad_scm/v8/third_party/jsoncpp/source6ggo9p8s/source b/deps/_bad_scm/v8/third_party/jsoncpp/source6ggo9p8s/source
@@ -0,0 +1 @@
+Subproject commit 69098a18b9af0c47549d9a271c054d13ca92b006
diff --git a/deps/_bad_scm/v8/third_party/jsoncpp/sourcedc2dqzak/source b/deps/_bad_scm/v8/third_party/jsoncpp/sourcedc2dqzak/source
@@ -0,0 +1 @@
+Subproject commit 69098a18b9af0c47549d9a271c054d13ca92b006
diff --git a/deps/_bad_scm/v8/third_party/jsoncpp/sourcehxw54yfa/source b/deps/_bad_scm/v8/third_party/jsoncpp/sourcehxw54yfa/source
@@ -0,0 +1 @@
+Subproject commit 69098a18b9af0c47549d9a271c054d13ca92b006
diff --git a/deps/_bad_scm/v8/third_party/jsoncpp/sourcel5r66uxg/source b/deps/_bad_scm/v8/third_party/jsoncpp/sourcel5r66uxg/source
@@ -0,0 +1 @@
+Subproject commit 69098a18b9af0c47549d9a271c054d13ca92b006
diff --git a/deps/_bad_scm/v8/third_party/logdog/logdog_m4csx4h/logdog b/deps/_bad_scm/v8/third_party/logdog/logdog_m4csx4h/logdog
@@ -0,0 +1 @@
+Subproject commit 0b2078a90f7a638d576b3a7c407d136f2fb62399
diff --git a/deps/_bad_scm/v8/third_party/logdog/logdogec0e1i_c/logdog b/deps/_bad_scm/v8/third_party/logdog/logdogec0e1i_c/logdog
@@ -0,0 +1 @@
+Subproject commit 0b2078a90f7a638d576b3a7c407d136f2fb62399
diff --git a/deps/_bad_scm/v8/third_party/logdog/logdogqjpdff3m/logdog b/deps/_bad_scm/v8/third_party/logdog/logdogqjpdff3m/logdog
@@ -0,0 +1 @@
+Subproject commit 0b2078a90f7a638d576b3a7c407d136f2fb62399
diff --git a/deps/_bad_scm/v8/third_party/logdog/logdogz8z7w2q2/logdog b/deps/_bad_scm/v8/third_party/logdog/logdogz8z7w2q2/logdog
@@ -0,0 +1 @@
+Subproject commit 0b2078a90f7a638d576b3a7c407d136f2fb62399
diff --git a/deps/_bad_scm/v8/third_party/markupsafe409zkf8v/markupsafe b/deps/_bad_scm/v8/third_party/markupsafe409zkf8v/markupsafe
@@ -0,0 +1 @@
+Subproject commit e582d7f0edb9d67499b0f5abd6ae5550e91da7f2
diff --git a/deps/_bad_scm/v8/third_party/markupsafe46jy0v1n/markupsafe b/deps/_bad_scm/v8/third_party/markupsafe46jy0v1n/markupsafe
@@ -0,0 +1 @@
+Subproject commit e582d7f0edb9d67499b0f5abd6ae5550e91da7f2
diff --git a/deps/_bad_scm/v8/third_party/markupsafekcv5vmlz/markupsafe b/deps/_bad_scm/v8/third_party/markupsafekcv5vmlz/markupsafe
@@ -0,0 +1 @@
+Subproject commit e582d7f0edb9d67499b0f5abd6ae5550e91da7f2
diff --git a/deps/_bad_scm/v8/third_party/markupsafeoy3lvkf_/markupsafe b/deps/_bad_scm/v8/third_party/markupsafeoy3lvkf_/markupsafe
@@ -0,0 +1 @@
+Subproject commit e582d7f0edb9d67499b0f5abd6ae5550e91da7f2
diff --git a/deps/_bad_scm/v8/third_party/markupsafeul60g_4m/markupsafe b/deps/_bad_scm/v8/third_party/markupsafeul60g_4m/markupsafe
@@ -0,0 +1 @@
+Subproject commit e582d7f0edb9d67499b0f5abd6ae5550e91da7f2
diff --git a/deps/_bad_scm/v8/third_party/perfetto1khcnf1n/perfetto b/deps/_bad_scm/v8/third_party/perfetto1khcnf1n/perfetto
@@ -0,0 +1 @@
+Subproject commit 7e8f2cf1c46c03e3cb6ab4aabdf34024627cd758
diff --git a/deps/_bad_scm/v8/third_party/perfetto59xyiro2/perfetto b/deps/_bad_scm/v8/third_party/perfetto59xyiro2/perfetto
@@ -0,0 +1 @@
+Subproject commit 7e8f2cf1c46c03e3cb6ab4aabdf34024627cd758
diff --git a/deps/_bad_scm/v8/third_party/perfettoio0fk6vb/perfetto b/deps/_bad_scm/v8/third_party/perfettoio0fk6vb/perfetto
@@ -0,0 +1 @@
+Subproject commit 7e8f2cf1c46c03e3cb6ab4aabdf34024627cd758
diff --git a/deps/_bad_scm/v8/third_party/protobuf45kexu_2/protobuf b/deps/_bad_scm/v8/third_party/protobuf45kexu_2/protobuf
@@ -0,0 +1 @@
+Subproject commit 3a4d9316aa9e3f0afec58e83ed744b0be4d337fa
diff --git a/deps/_bad_scm/v8/third_party/protobufdttsgzae/protobuf b/deps/_bad_scm/v8/third_party/protobufdttsgzae/protobuf
@@ -0,0 +1 @@
+Subproject commit 3a4d9316aa9e3f0afec58e83ed744b0be4d337fa
diff --git a/deps/_bad_scm/v8/third_party/protobufvzxi4x9o/protobuf b/deps/_bad_scm/v8/third_party/protobufvzxi4x9o/protobuf
@@ -0,0 +1 @@
+Subproject commit 3a4d9316aa9e3f0afec58e83ed744b0be4d337fa
diff --git a/deps/_bad_scm/v8/third_party/zlibbiqlwjt6/zlib b/deps/_bad_scm/v8/third_party/zlibbiqlwjt6/zlib
@@ -0,0 +1 @@
+Subproject commit 24c07df5033183efad8607cba62e746bea7180bf
diff --git a/deps/_bad_scm/v8/third_party/zlibg1fgy2dr/zlib b/deps/_bad_scm/v8/third_party/zlibg1fgy2dr/zlib
@@ -0,0 +1 @@
+Subproject commit 24c07df5033183efad8607cba62e746bea7180bf
diff --git a/deps/_bad_scm/v8/third_party/zlibhxv09vhw/zlib b/deps/_bad_scm/v8/third_party/zlibhxv09vhw/zlib
@@ -0,0 +1 @@
+Subproject commit 24c07df5033183efad8607cba62e746bea7180bf
diff --git a/deps/_bad_scm/v8/third_party/zlibjwzrlqic/zlib b/deps/_bad_scm/v8/third_party/zlibjwzrlqic/zlib
@@ -0,0 +1 @@
+Subproject commit 24c07df5033183efad8607cba62e746bea7180bf
diff --git a/deps/_bad_scm/v8/third_party/zlibzv599s24/zlib b/deps/_bad_scm/v8/third_party/zlibzv599s24/zlib
@@ -0,0 +1 @@
+Subproject commit 24c07df5033183efad8607cba62e746bea7180bf
diff --git a/deps/_bad_scm/v8/tools/clangc_s32q5b/clang b/deps/_bad_scm/v8/tools/clangc_s32q5b/clang
@@ -0,0 +1 @@
+Subproject commit b341c2ddaa6560b85ab80a785011f7e956b25003
diff --git a/deps/_bad_scm/v8/tools/clango_v06tzh/clang b/deps/_bad_scm/v8/tools/clango_v06tzh/clang
@@ -0,0 +1 @@
+Subproject commit b341c2ddaa6560b85ab80a785011f7e956b25003
diff --git a/deps/_bad_scm/v8/tools/clangrjyel0bx/clang b/deps/_bad_scm/v8/tools/clangrjyel0bx/clang
@@ -0,0 +1 @@
+Subproject commit b341c2ddaa6560b85ab80a785011f7e956b25003
diff --git a/deps/_bad_scm/v8/tools/clangwr99im5x/clang b/deps/_bad_scm/v8/tools/clangwr99im5x/clang
@@ -0,0 +1 @@
+Subproject commit b341c2ddaa6560b85ab80a785011f7e956b25003
diff --git a/test/parallel/test-worker-env-option-with-v8-cli-flags.js b/test/parallel/test-worker-env-option-with-v8-cli-flags.js
@@ -0,0 +1,9 @@
+// Flags: --expose_gc
+'use strict';
+require('../common');
+const { Worker } = require('worker_threads');
+
+// Test that it does not crash
+new Worker('', { eval: true, env: {} });
+new Worker('', { eval: true, env: process.env });
+new Worker('', { eval: true, env: { HELLO: 'hi!' } });

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 4c678ca2630e871ee5e975f6fe84542c3701417f`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit ca4997ede874d6caaf5393a2d6d503b68d5d39dc`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 6551a7eb433575243c5212bd2be9ef0930e2dcca`