Skip to content

Commit 3d43bce

Browse files
addaleaxtargos
authored andcommitted
deps: cherry-pick 98c40a4bae915 from V8 upstream
Original commit message: [platform] Return task runners as shared_ptr At the moment, task runners are returned as unique_ptr. This is inconvenient, however. In all implementations I did, the platform holds a shared pointer of the task runner and wraps it in a wrapper class just to return it as a unique_ptr. With this CL the platform API is changed to return a shared_ptr directly. [email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ide278db855199ea239ad0ae14d97fd17349dac8c Reviewed-on: https://chromium-review.googlesource.com/768867 Commit-Queue: Andreas Haas <[email protected]> Reviewed-by: Ross McIlroy <[email protected]> Cr-Commit-Position: refs/heads/master@{#49366} Refs: v8/v8@98c40a4 PR-URL: #17134 Fixes: nodejs/node-v8#24 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 99ac5cd commit 3d43bce

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.2',
30+
'v8_embedder_string': '-node.3',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/include/v8-platform.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ class Platform {
199199
* Returns a TaskRunner which can be used to post a task on the foreground.
200200
* This function should only be called from a foreground thread.
201201
*/
202-
virtual std::unique_ptr<v8::TaskRunner> GetForegroundTaskRunner(
202+
virtual std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
203203
Isolate* isolate) {
204204
// TODO(ahaas): Make this function abstract after it got implemented on all
205205
// platforms.
@@ -210,7 +210,7 @@ class Platform {
210210
* Returns a TaskRunner which can be used to post a task on a background.
211211
* This function should only be called from a foreground thread.
212212
*/
213-
virtual std::unique_ptr<v8::TaskRunner> GetBackgroundTaskRunner(
213+
virtual std::shared_ptr<v8::TaskRunner> GetBackgroundTaskRunner(
214214
Isolate* isolate) {
215215
// TODO(ahaas): Make this function abstract after it got implemented on all
216216
// platforms.

0 commit comments

Comments
 (0)