Skip to content

Commit 4195c31

Browse files
Trottaddaleax
authored andcommitted
test: fix flaky test-http2-reset-flood
Set `allowHalfOpen: true` in the client. Fixes: #29802 Refs: #31806 PR-URL: #34318 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
1 parent a038199 commit 4195c31

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

test/parallel/parallel.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ prefix parallel
55
# sample-test : PASS,FLAKY
66

77
[true] # This section applies to all platforms
8-
# https://github.com/nodejs/node/issues/29802
9-
test-http2-reset-flood: PASS,FLAKY
108

119
[$system==win32]
1210
# https://github.com/nodejs/node/issues/32863
@@ -46,8 +44,6 @@ test-crypto-keygen: SKIP
4644
[$system==freebsd]
4745
# https://github.com/nodejs/node/issues/31727
4846
test-fs-stat-bigint: PASS,FLAKY
49-
# https://github.com/nodejs/node/issues/29802
50-
test-http2-reset-flood: PASS,FLAKY
5147
# https://github.com/nodejs/node/issues/28803
5248
test-stdout-close-catch: PASS,FLAKY
5349
# https://github.com/nodejs/node/issues/31280

test/parallel/test-http2-reset-flood.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) {
2828
process.env.HAS_STARTED_WORKER = 1;
2929
const worker = new Worker(__filename).on('message', common.mustCall((port) => {
3030
const h2header = Buffer.alloc(9);
31-
const conn = net.connect(port);
31+
const conn = net.connect({ port, allowHalfOpen: true });
3232

3333
conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n');
3434

0 commit comments

Comments
 (0)