@@ -180,14 +180,14 @@ To nominate a new Collaborator:
180
180
block, add a comment in the private discussion stating you're planning on
181
181
opening a public issue, e.g. "I see a number of approvals and no block, I'll
182
182
be opening a public nomination issue if I don't hear any objections in the
183
- next 72 hours".
183
+ next 72 hours". _ Ideally_ this should only be done after any questions,
184
+ concerns, objects, etc have been resolved.
184
185
3 . ** Optional but strongly recommended** : Privately contact the nominee to make
185
186
sure they're comfortable with the nomination.
186
187
4 . Open an issue in the [ nodejs/node] [ ] repository. Provide a summary of
187
188
the nominee's contributions (see below for an example). Mention
188
189
@nodejs/collaborators in the issue to notify other collaborators about
189
- the nomination. _ Ideally_ , this issue should not be opened until any private
190
- discussion (questions, concerns, objections, etc) has been resolved.
190
+ the nomination.
191
191
192
192
The _ Optional but strongly recommended_ steps are optional in the sense that
193
193
skipping them would not invalidate the nomination, but it could put the nominee
@@ -214,12 +214,12 @@ Example of list of contributions:
214
214
organization
215
215
* Other participation in the wider Node.js community
216
216
217
- The nomination passes if no collaborators _ explicitly _ oppose it after one week.
218
- In the case of an objection, the TSC is responsible for working with the
219
- individuals involved and finding a resolution. The TSC may, following
220
- typical TSC consensus seeking processes, choose to advance a nomination that
221
- has otherwise failed to reach a natural consensus or clear path forward even
222
- if there are outstanding objections.
217
+ The nomination passes if no collaborators oppose it (as described in the
218
+ following section) after one week. In the case of an objection, the TSC is
219
+ responsible for working with the individuals involved and finding a resolution.
220
+ The TSC may, following typical TSC consensus seeking processes, choose to
221
+ advance a nomination that has otherwise failed to reach a natural consensus or
222
+ clear path forward even if there are outstanding objections.
223
223
224
224
Explicit opposition would typically be signaled as some form of clear
225
225
and unambiguous comment like, "I don't believe this nomination should pass".
@@ -235,11 +235,6 @@ discussion and review around the proposal should ideally be more geared
235
235
towards "I have reasons to say no..." as opposed to "Give me reasons to say
236
236
yes...".
237
237
238
- Refrain from discussing or debating aspects of the nomination process
239
- itself directly within a nomination private discussion or public issue.
240
- Such discussions can derail and frustrate the nomination and cause unnecessary
241
- friction. Move such discussions to a separate issue or discussion thread.
242
-
243
238
#### How to review a collaborator nomination
244
239
245
240
A collaborator nomination can be reviewed in the same way one would review a PR
@@ -263,6 +258,25 @@ push commits, etc.), so what's the minimal amount is subjective, and there will
263
258
be cases where collaborators disagree on whether a nomination should move
264
259
forward.
265
260
261
+ Refrain from discussing or debating aspects of the nomination process
262
+ itself directly within a nomination private discussion or public issue.
263
+ Such discussions can derail and frustrate the nomination and cause unnecessary
264
+ friction. Move such discussions to a separate issue or discussion thread.
265
+
266
+ #### The Authenticity of Contributors
267
+
268
+ The Node.js project does not require that contributors use their legal names or
269
+ provide any personal information verifying their identity.
270
+
271
+ It is not uncommon for malicious actors to attempt to gain commit access to
272
+ open-source projects in order to inject malicious code or for other nefarious
273
+ purposes. The Node.js project has a number of mechanisms in place to prevent
274
+ this, but it is important to be vigilant. If you have concerns about the
275
+ authenticity of a contributor, please raise them with the TSC. Anyone nominating
276
+ a new collaborator should take reasonable steps to verify that the contributions
277
+ of the nominee are authentic and made in good faith. This is not always easy,
278
+ but it is important.
279
+
266
280
### Onboarding
267
281
268
282
After the nomination passes, a TSC member onboards the new collaborator. See
0 commit comments