src: implement changes suggested by @addaleax

kokke · nodejs-github-bot · commit 4f3eda66cc69 · 2021-09-30T14:41:39.000Z
Refs: #40128 PR-URL: #40128 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/crypto/crypto_context.cc b/src/crypto/crypto_context.cc
@@ -1114,7 +1114,7 @@ int SecureContext::TicketKeyCallback(SSL* ssl,
     return -1;
   }
 
-  argv[2] = v8::True(env->isolate());
+  argv[2] = enc != 0 ? v8::True(env->isolate()) : v8::False(env->isolate());
 
   Local<Value> ret;
   if (!node::MakeCallback(

Original file line number	Diff line number	Diff line change
`@@ -1114,7 +1114,7 @@ int SecureContext::TicketKeyCallback(SSL* ssl,`
`1114`	`1114`	`return -1;`
`1115`	`1115`	`}`
`1116`	`1116`
`1117`		`- argv[2] = v8::True(env->isolate());`
	`1117`	`+ argv[2] = enc != 0 ? v8::True(env->isolate()) : v8::False(env->isolate());`
`1118`	`1118`
`1119`	`1119`	`Local<Value> ret;`
`1120`	`1120`	`if (!node::MakeCallback(`