Skip to content

Commit 5125c08

Browse files
Trottjasnell
authored andcommitted
test: remove obsolete debugger tests
The tests in `test/debugger` all fail since the removal of the pre-inspector debugger (if they weren't already failing). They do not run in CI (probably because they were never reliable). Remove them and associated fixtures. PR-URL: #15139 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent b58a2aa commit 5125c08

14 files changed

+3
-555
lines changed

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,6 @@ test-pummel: all
386386
test-internet: all
387387
$(PYTHON) tools/test.py internet
388388

389-
test-debugger: all
390-
$(PYTHON) tools/test.py debugger
391-
392389
test-inspector: all
393390
$(PYTHON) tools/test.py inspector
394391

doc/api/debugger.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,18 +125,18 @@ It is also possible to set a breakpoint in a file (module) that
125125
is not loaded yet:
126126

127127
```txt
128-
$ node inspect test/fixtures/break-in-module/main.js
128+
$ node inspect main.js
129129
< Debugger listening on ws://127.0.0.1:9229/4e3db158-9791-4274-8909-914f7facf3bd
130130
< For help see https://nodejs.org/en/docs/inspector
131131
< Debugger attached.
132-
Break on start in test/fixtures/break-in-module/main.js:1
132+
Break on start in main.js:1
133133
> 1 (function (exports, require, module, __filename, __dirname) { const mod = require('./mod.js');
134134
2 mod.hello();
135135
3 mod.hello();
136136
debug> setBreakpoint('mod.js', 22)
137137
Warning: script 'mod.js' was not loaded yet.
138138
debug> c
139-
break in test/fixtures/break-in-module/mod.js:22
139+
break in mod.js:22
140140
20 // USE OR OTHER DEALINGS IN THE SOFTWARE.
141141
21
142142
>22 exports.hello = function() {

test/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ On how to run tests in this directory, see
1616
|addons |Yes |Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon to function properly.|
1717
|cctest |Yes |C++ test that is run as part of the build process.|
1818
|common | |Common modules shared among many tests. [Documentation](./common/README.md)|
19-
|debugger |No |Tests for [debugger](https://nodejs.org/api/debugger.html) functionality along with some tests that require an addon to function properly.|
2019
|fixtures | |Test fixtures used in various tests throughout the test suite.|
2120
|gc |No |Tests for garbage collection related functionality.|
2221
|inspector |Yes |Tests for the V8 inspector integration.|

test/debugger/helper-debugger-repl.js

Lines changed: 0 additions & 150 deletions
This file was deleted.

test/debugger/test-debugger-repl-break-in-module.js

Lines changed: 0 additions & 82 deletions
This file was deleted.

test/debugger/test-debugger-repl-restart.js

Lines changed: 0 additions & 42 deletions
This file was deleted.

test/debugger/test-debugger-repl-term.js

Lines changed: 0 additions & 65 deletions
This file was deleted.

0 commit comments

Comments
 (0)