Skip to content

Commit 56677b6

Browse files
kt3kMylesBorins
authored andcommitted
test: improve test-stream2-objects.js
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 15f2165 commit 56677b6

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/parallel/test-stream2-objects.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function run() {
3333

3434
// ensure all tests have run
3535
process.on('exit', function() {
36-
assert.equal(count, 0);
36+
assert.strictEqual(count, 0);
3737
});
3838

3939
process.nextTick(run);
@@ -210,16 +210,16 @@ test('high watermark _read', function(t) {
210210

211211
var v = r.read();
212212

213-
assert.equal(calls, 0);
214-
assert.equal(v, '1');
213+
assert.strictEqual(calls, 0);
214+
assert.strictEqual(v, '1');
215215

216216
var v2 = r.read();
217-
assert.equal(v2, '2');
217+
assert.strictEqual(v2, '2');
218218

219219
var v3 = r.read();
220-
assert.equal(v3, '3');
220+
assert.strictEqual(v3, '3');
221221

222-
assert.equal(calls, 1);
222+
assert.strictEqual(calls, 1);
223223

224224
t.end();
225225
});
@@ -232,7 +232,7 @@ test('high watermark push', function(t) {
232232
r._read = function(n) {};
233233
for (var i = 0; i < 6; i++) {
234234
var bool = r.push(i);
235-
assert.equal(bool, i === 5 ? false : true);
235+
assert.strictEqual(bool, i !== 5);
236236
}
237237

238238
t.end();
@@ -309,7 +309,7 @@ test('buffers finish until cb is called', function(t) {
309309
var called = false;
310310

311311
w._write = function(chunk, encoding, cb) {
312-
assert.equal(chunk, 'foo');
312+
assert.strictEqual(chunk, 'foo');
313313

314314
process.nextTick(function() {
315315
called = true;
@@ -318,7 +318,7 @@ test('buffers finish until cb is called', function(t) {
318318
};
319319

320320
w.on('finish', function() {
321-
assert.equal(called, true);
321+
assert.strictEqual(called, true);
322322

323323
t.end();
324324
});

0 commit comments

Comments
 (0)