Skip to content

Commit 567284f

Browse files
committed
squash: improvements
1 parent 9df45db commit 567284f

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

lib/assert.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@ function _throws(shouldThrow, block, expected, message) {
341341

342342
actual = _tryBlock(block);
343343

344-
message = (expected && expected.name ? ' (' + expected.name + ').' : '.') +
345-
(message ? ' ' + message : '');
344+
message = (expected && expected.name ? ' (' + expected.name + ')' : '') +
345+
(message ? ': ' + message : '.');
346346

347347
if (shouldThrow && !actual) {
348348
fail(actual, expected, 'Missing expected exception' + message);

test/parallel/test-assert.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,29 @@ a.throws(makeBlock(a.deepEqual, args, []));
489489
a.doesNotThrow(makeBlock(a.deepEqual, someArgs, sameArgs));
490490
}
491491

492+
// check messages from assert.throws()
493+
{
494+
assert.throws(
495+
() => { a.throws(() => {}); },
496+
/^AssertionError: Missing expected exception\.$/
497+
);
498+
499+
assert.throws(
500+
() => { a.throws(() => {}, TypeError); },
501+
/^AssertionError: Missing expected exception \(TypeError\)\.$/
502+
);
503+
504+
assert.throws(
505+
() => { a.throws(() => {}, 'fhqwhgads'); },
506+
/^AssertionError: Missing expected exception: fhqwhgads$/
507+
);
508+
509+
assert.throws(
510+
() => { a.throws(() => {}, TypeError, 'fhqwhgads'); },
511+
/^AssertionError: Missing expected exception \(TypeError\): fhqwhgads$/
512+
);
513+
}
514+
492515
const circular = {y: 1};
493516
circular.x = circular;
494517

0 commit comments

Comments
 (0)