Skip to content

Commit 5fdfcc0

Browse files
TrottBethGriggs
authored andcommitted
doc: remove outdated step in onboarding exercise
The GitHub bot will leave a comment asking people to thumbs-up a fast track request so there is no need to manually leave such a comment. PR-URL: #39410 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 94706c7 commit 5fdfcc0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

onboarding.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,12 @@ needs to be pointed out separately during the onboarding.
204204
so that when the commit lands, the nomination issue url will be
205205
automatically closed.
206206
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
207-
labels.
207+
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
208+
comment in the pull request asking collaborators to approve the pull request
209+
by leaving a 👍 reaction on the comment.
208210
* Run CI on the pull request. Use the `node-test-pull-request` CI task.
209211
* After two Collaborator approvals for the change and two Collaborator approvals
210-
for fast-tracking, land the pull request.
211-
* Leave a comment in the pull request:
212-
`Please 👍 this comment to approve fast-tracking`.
212+
for fast-tracking, land the PR.
213213
* If there are not enough approvals within a reasonable time, consider the
214214
single approval of the onboarding TSC member sufficient, and land the pull
215215
request.

0 commit comments

Comments
 (0)