Skip to content

Commit 60b697d

Browse files
zjiazBethGriggs
authored andcommitted
deps: V8: cherry-pick 7889803e82d3
Original commit message: [mips] Use t9 as the function call register. on mips, we should use t9 when jump to a ExternalReference, because the callee function will consider t9 as the function start address. Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417 Auto-Submit: Yu Yin <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/master@{#63988} Refs: v8/v8@7889803 PR-URL: #34214 Fixes: #33703 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
1 parent 79c4c73 commit 60b697d

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.39',
37+
'v8_embedder_string': '-node.40',
3838

3939
##### V8 defaults for Node.js #####
4040

deps/v8/src/codegen/mips/macro-assembler-mips.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3853,10 +3853,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
38533853
}
38543854

38553855
void TurboAssembler::Jump(const ExternalReference& reference) {
3856-
UseScratchRegisterScope temps(this);
3857-
Register scratch = temps.Acquire();
3858-
li(scratch, reference);
3859-
Jump(scratch);
3856+
li(t9, reference);
3857+
Jump(t9);
38603858
}
38613859

38623860
void MacroAssembler::JumpIfIsInRange(Register value, unsigned lower_limit,

deps/v8/src/codegen/mips64/macro-assembler-mips64.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4202,10 +4202,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
42024202
}
42034203

42044204
void TurboAssembler::Jump(const ExternalReference& reference) {
4205-
UseScratchRegisterScope temps(this);
4206-
Register scratch = temps.Acquire();
4207-
li(scratch, reference);
4208-
Jump(scratch);
4205+
li(t9, reference);
4206+
Jump(t9);
42094207
}
42104208

42114209
// Note: To call gcc-compiled C code on mips, you must call through t9.

0 commit comments

Comments
 (0)