Skip to content

Commit 6e4598d

Browse files
TrottMyles Borins
authored and
Myles Borins
committed
test: remove unused variables from TLS tests
Some of the TLS tests have variables that do not get used. This removes those variables. PR-URL: #4424 Reviewed-By: Johan Bergström <[email protected]>
1 parent 7b1aa04 commit 6e4598d

19 files changed

+3
-20
lines changed

test/parallel/test-tls-0-dns-altname.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if (!common.hasCrypto) {
99
var tls = require('tls');
1010

1111
var fs = require('fs');
12-
var net = require('net');
1312

1413
var common = require('../common');
1514

test/parallel/test-tls-async-cb-after-socket-end.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
var common = require('../common');
44

5-
var assert = require('assert');
65
var path = require('path');
76
var fs = require('fs');
87
var constants = require('constants');

test/parallel/test-tls-client-default-ciphers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function test1() {
1919
};
2020

2121
try {
22-
var s = tls.connect(common.PORT);
22+
tls.connect(common.PORT);
2323
} catch (e) {
2424
assert(e instanceof Done);
2525
}

test/parallel/test-tls-close-error.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ if (!common.hasCrypto) {
1010
var tls = require('tls');
1111

1212
var fs = require('fs');
13-
var net = require('net');
1413

1514
var errorCount = 0;
1615
var closeCount = 0;

test/parallel/test-tls-close-notify.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if (!common.hasCrypto) {
99
var tls = require('tls');
1010

1111
var fs = require('fs');
12-
var net = require('net');
1312

1413
var ended = 0;
1514

test/parallel/test-tls-destroy-whilst-write.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
'use strict';
2-
var assert = require('assert');
32
var common = require('../common');
43

54
if (!common.hasCrypto) {

test/parallel/test-tls-fast-writing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var server = tls.createServer(options, onconnection);
2020
var gotChunk = false;
2121
var gotDrain = false;
2222

23-
var timer = setTimeout(function() {
23+
setTimeout(function() {
2424
console.log('not ok - timed out');
2525
process.exit(1);
2626
}, common.platformTimeout(500));

test/parallel/test-tls-handshake-error.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ if (!common.hasCrypto) {
1010
var tls = require('tls');
1111

1212
var fs = require('fs');
13-
var net = require('net');
1413

1514
var errorCount = 0;
1615
var closeCount = 0;

test/parallel/test-tls-handshake-nohang.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22
var common = require('../common');
3-
var assert = require('assert');
43

54
if (!common.hasCrypto) {
65
console.log('1..0 # Skipped: missing crypto');

test/parallel/test-tls-invoke-queued.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if (!common.hasCrypto) {
99
var tls = require('tls');
1010

1111
var fs = require('fs');
12-
var net = require('net');
1312

1413

1514
var received = '';

test/parallel/test-tls-key-mismatch.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ var options = {
1414
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem')
1515
};
1616

17-
var cert = null;
18-
1917
assert.throws(function() {
2018
tls.createSecureContext(options);
2119
});

test/parallel/test-tls-max-send-fragment.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if (!common.hasCrypto) {
99
var tls = require('tls');
1010

1111
var fs = require('fs');
12-
var net = require('net');
1312

1413
var common = require('../common');
1514

test/parallel/test-tls-ocsp-callback.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ function test(testOptions, cb) {
4141
var clientSecure = 0;
4242
var ocspCount = 0;
4343
var ocspResponse;
44-
var session;
4544

4645
if (testOptions.pfx) {
4746
delete options.key;

test/parallel/test-tls-peer-certificate-encoding.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ var tls = require('tls');
1111
var fs = require('fs');
1212
var util = require('util');
1313
var join = require('path').join;
14-
var spawn = require('child_process').spawn;
1514

1615
var options = {
1716
key: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent5-key.pem')),

test/parallel/test-tls-peer-certificate-multi-keys.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ var tls = require('tls');
1111
var fs = require('fs');
1212
var util = require('util');
1313
var join = require('path').join;
14-
var spawn = require('child_process').spawn;
1514

1615
var options = {
1716
key: fs.readFileSync(join(common.fixturesDir, 'agent.key')),

test/parallel/test-tls-peer-certificate.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ var tls = require('tls');
1111
var fs = require('fs');
1212
var util = require('util');
1313
var join = require('path').join;
14-
var spawn = require('child_process').spawn;
1514

1615
var options = {
1716
key: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent1-key.pem')),

test/parallel/test-tls-request-timeout.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ var server = tls.Server(options, function(socket) {
2929
});
3030

3131
server.listen(common.PORT, function() {
32-
var socket = tls.connect({
32+
tls.connect({
3333
port: common.PORT,
3434
rejectUnauthorized: false
3535
});

test/parallel/test-tls-socket-default-options.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if (!common.hasCrypto) {
99
const tls = require('tls');
1010

1111
const fs = require('fs');
12-
const net = require('net');
1312

1413
const sent = 'hello world';
1514

test/parallel/test-tls-ticket-cluster.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ if (cluster.isMaster) {
4242

4343
function fork() {
4444
var worker = cluster.fork();
45-
var workerReqCount = 0;
4645
worker.on('message', function(msg) {
4746
console.error('[master] got %j', msg);
4847
if (msg === 'reused') {

0 commit comments

Comments
 (0)