Skip to content

Commit 6eed6a3

Browse files
bnoordhuisevanlucas
authored andcommitted
build,test: fix build-addons dependency chain
* Make the 'extract embedded addons in the documentations' step a normal prerequisite. As an order-only prerequisite, it's sometimes skipped when it shouldn't be. * Make `tools/doc/addon-verify.js` a dependency of that step. Changes to that file should result in a rebuild. PR-URL: #6652 Reviewed-By: Anna Henningsen <[email protected]>
1 parent edb29b8 commit 6eed6a3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,9 @@ test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
133133
--nodedir="$(shell pwd)"
134134

135135
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
136-
test/addons/.docbuildstamp: doc/api/addons.md
136+
test/addons/.docbuildstamp: tools/doc/addon-verify.js doc/api/addons.md
137137
$(RM) -r test/addons/??_*/
138-
$(NODE) tools/doc/addon-verify.js
138+
$(NODE) $<
139139
touch $@
140140

141141
ADDONS_BINDING_GYPS := \
@@ -146,7 +146,7 @@ ADDONS_BINDING_GYPS := \
146146
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \
147147
deps/uv/include/*.h deps/v8/include/*.h \
148148
src/node.h src/node_buffer.h src/node_object_wrap.h \
149-
| test/addons/.docbuildstamp
149+
test/addons/.docbuildstamp
150150
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
151151
# embedded addons have been generated from the documentation.
152152
for dirname in test/addons/*/; do \

0 commit comments

Comments
 (0)