Skip to content

Commit 7188b95

Browse files
cjihrigMylesBorins
authored andcommitted
src: fix -Winconsistent-missing-override warning
This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe<bool> mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( PR-URL: #30549 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]>
1 parent 18ec8a8 commit 7188b95

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_api.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ {
2626
}
2727

2828
v8::Maybe<bool> mark_arraybuffer_as_untransferable(
29-
v8::Local<v8::ArrayBuffer> ab) const {
29+
v8::Local<v8::ArrayBuffer> ab) const override {
3030
return ab->SetPrivate(
3131
context(),
3232
node_env()->arraybuffer_untransferable_private_symbol(),

0 commit comments

Comments
 (0)