Skip to content

Commit 725a2b1

Browse files
Trotttargos
authored andcommitted
tools: simplify ESLint invocation in Makefile
Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js. PR-URL: #22348 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent c207865 commit 725a2b1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ module.exports = {
187187
message: 'Use new keyword when throwing an Error.',
188188
}
189189
],
190-
/* eslint-enable max-len, quotes */
190+
/* eslint-enable max-len */
191191
'no-return-await': 'error',
192192
'no-self-assign': 'error',
193193
'no-self-compare': 'error',

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,7 @@ endif
11201120
LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools
11211121

11221122
run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \
1123-
--ext=.js,.mjs,.md $(LINT_JS_TARGETS) --ignore-pattern '!.eslintrc.js'
1123+
--ext=.js,.mjs,.md $(LINT_JS_TARGETS)
11241124
run-lint-js-fix = $(run-lint-js) --fix
11251125

11261126
.PHONY: lint-js-fix

0 commit comments

Comments
 (0)