src: add self-assigment memcpy checks

Fixes: #56718
PR-URL: #56986
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Author: wooffie

src/node_sockaddr-inl.h

@@ -79,12 +79,16 @@ SocketAddress::SocketAddress(const SocketAddress& addr) {
 }
 
 SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
-  memcpy(&address_, addr, GetLength(addr));
+  if (reinterpret_cast<const sockaddr*>(&address_) != addr) {
+    memcpy(&address_, addr, GetLength(addr));
+  }
   return *this;
 }
 
 SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
-  memcpy(&address_, &addr.address_, addr.length());
+  if (this != &addr) {
+    memcpy(&address_, &addr.address_, addr.length());
+  }
   return *this;
 }