Skip to content

Commit 86527bd

Browse files
devsnekapapirovski
authored andcommitted
util: fix negative 0 check in inspect
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent e9d1e12 commit 86527bd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/util.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -597,10 +597,8 @@ function formatValue(ctx, value, recurseTimes, ln) {
597597
}
598598

599599
function formatNumber(fn, value) {
600-
// Format -0 as '-0'. A `value === -0` check won't distinguish 0 from -0.
601-
// Using a division check is currently faster than `Object.is(value, -0)`
602-
// as of V8 6.1.
603-
if (1 / value === -Infinity)
600+
// Format -0 as '-0'. Checking `value === -0` won't distinguish 0 from -0.
601+
if (Object.is(value, -0))
604602
return fn('-0', 'number');
605603
return fn(`${value}`, 'number');
606604
}

test/parallel/test-util-inspect.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,8 @@ assert.strictEqual(
417417
// test positive/negative zero
418418
assert.strictEqual(util.inspect(0), '0');
419419
assert.strictEqual(util.inspect(-0), '-0');
420+
// edge case from check
421+
assert.strictEqual(util.inspect(-5e-324), '-5e-324');
420422

421423
// test for sparse array
422424
{

0 commit comments

Comments
 (0)