Skip to content

Commit 8ef86a9

Browse files
gengjiawenjasnell
authored andcommitted
quic: fix clang warning
PR-URL: #33963 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 680644a commit 8ef86a9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/quic/node_quic_crypto.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,9 @@ Local<Value> GetALPNProtocol(const QuicSession& session) {
560560
QuicCryptoContext* ctx = session.crypto_context();
561561
Environment* env = session.env();
562562
std::string alpn = ctx->selected_alpn();
563-
if (alpn == NGTCP2_ALPN_H3 + 1) {
563+
// This supposed to be `NGTCP2_ALPN_H3 + 1`
564+
// Details see https://github.com/nodejs/node/issues/33959
565+
if (alpn == &NGTCP2_ALPN_H3[1]) {
564566
return env->quic_alpn_string();
565567
} else {
566568
return ToV8Value(

0 commit comments

Comments
 (0)