test: properly order freeing resources in cctest

addaleax · addaleax · commit 93f25f4b44e3 · 2017-08-10T22:08:56.000+02:00
The `IsolateData` instance is created before the `Environment` instance, so free in reverse order. Fixes: #14206 PR-URL: #14749 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc
@@ -41,9 +41,9 @@ class EnvironmentTest : public NodeTestFixture {
     }
 
     ~Env() {
-      FreeIsolateData(isolate_data_);
       environment_->CleanupHandles();
       FreeEnvironment(environment_);
+      FreeIsolateData(isolate_data_);
     }
 
     Environment* operator*() const {

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,9 @@ class EnvironmentTest : public NodeTestFixture {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`~Env() {`
`44`		`- FreeIsolateData(isolate_data_);`
`45`	`44`	`environment_->CleanupHandles();`
`46`	`45`	`FreeEnvironment(environment_);`
	`46`	`+ FreeIsolateData(isolate_data_);`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`Environment* operator*() const {`