Skip to content

Commit 94039b7

Browse files
Trottaddaleax
authored andcommitted
doc: edit (general) collaborator guide
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: #34712 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
1 parent 380600d commit 94039b7

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

doc/guides/collaborator-guide.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,15 @@ and the objector must remain responsive for further discussion towards
131131
consensus about the direction of the pull request**. Providing a set of
132132
actionable steps alongside the objection is recommended.
133133

134-
If the objection is not clear to others, another Collaborator may ask an
135-
objecting Collaborator to explain their objection or to provide actionable
134+
If the objection is not clear to others, another collaborator may ask an
135+
objecting collaborator to explain their objection or to provide actionable
136136
steps to resolve the objection. **If the objector is unresponsive for seven
137-
days after a collaborator asks for clarification, another Collaborator may
137+
days after a collaborator asks for clarification, another collaborator may
138138
dismiss the objection**.
139139

140140
**Pull requests with outstanding objections must remain open until all
141141
objections are satisfied**. If reaching consensus is not possible, a
142-
Collaborator may escalate the issue to the TSC by pinging `@nodejs/tsc` and
142+
collaborator may escalate the issue to the TSC by pinging `@nodejs/tsc` and
143143
adding the `tsc-agenda` label to the issue.
144144

145145
#### Helpful resources
@@ -416,7 +416,7 @@ Do this if a pull request or issue:
416416
[TSC][]. Do not use the GitHub UI on the right-hand side to assign to
417417
`@nodejs/tsc` or request a review from `@nodejs/tsc`.
418418

419-
The TSC should serve as the final arbiter where required.
419+
The TSC serves as the final arbiter where required.
420420

421421
## Landing Pull Requests
422422

@@ -451,7 +451,7 @@ tests. This makes it much easier when bisecting to find a breaking change.
451451
### Using `git-node`
452452

453453
In most cases, using [the `git-node` command][git-node] of [`node-core-utils`][]
454-
should be enough to land a pull request. If you discover a problem when using
454+
is enough to land a pull request. If you discover a problem when using
455455
this tool, please file an issue [to the issue tracker][node-core-utils-issues].
456456

457457
Quick example:
@@ -621,8 +621,8 @@ Time to push it:
621621
$ git push upstream master
622622
```
623623

624-
Close the pull request with a "Landed in `<commit hash>`" comment. If
625-
your pull request shows the purple merged status then you should still
624+
Close the pull request with a "Landed in `<commit hash>`" comment. Even if
625+
your pull request shows the purple merged status,
626626
add the "Landed in \<commit hash>..\<commit hash>" comment if you added
627627
more than one commit.
628628

0 commit comments

Comments
 (0)