test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: #7045
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>

Author: mscdex

test/parallel/test-async-wrap-check-providers.js

@@ -76,12 +76,12 @@ net.createServer(function(c) {
 net.createServer(function(c) {
   c.end();
   this.close(checkTLS);
-}).listen(common.PORT, function() {
-  net.connect(common.PORT, noop);
+}).listen(0, function() {
+  net.connect(this.address().port, noop);
 });
 
-dgram.createSocket('udp4').bind(common.PORT, function() {
-  this.send(new Buffer(2), 0, 2, common.PORT, '::', () => {
+dgram.createSocket('udp4').bind(0, function() {
+  this.send(new Buffer(2), 0, 2, this.address().port, '::', () => {
     this.close();
   });
 });
@@ -95,8 +95,9 @@ function checkTLS() {
     cert: fs.readFileSync(common.fixturesDir + '/keys/ec-cert.pem')
   };
   const server = tls.createServer(options, noop)
-    .listen(common.PORT, function() {
-      tls.connect(common.PORT, { rejectUnauthorized: false }, function() {
+    .listen(0, function() {
+      const connectOpts = { rejectUnauthorized: false };
+      tls.connect(this.address().port, connectOpts, function() {
         this.destroy();
         server.close();
       });

test/parallel/test-async-wrap-disabled-propagate-parent.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const net = require('net');
 const async_wrap = process.binding('async_wrap');
@@ -40,8 +40,8 @@ const server = net.createServer(function(c) {
     c.end();
     this.close();
   });
-}).listen(common.PORT, function() {
-  net.connect(common.PORT, noop);
+}).listen(0, function() {
+  net.connect(this.address().port, noop);
 });
 
 async_wrap.disable();

test/parallel/test-async-wrap-propagate-parent.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const net = require('net');
 const async_wrap = process.binding('async_wrap');
@@ -40,8 +40,8 @@ const server = net.createServer(function(c) {
     c.end();
     this.close();
   });
-}).listen(common.PORT, function() {
-  net.connect(common.PORT, noop);
+}).listen(0, function() {
+  net.connect(this.address().port, noop);
 });
 
 

test/parallel/test-beforeexit-event.js

@@ -1,7 +1,7 @@
 'use strict';
+require('../common');
 var assert = require('assert');
 var net = require('net');
-var common = require('../common');
 var revivals = 0;
 var deaths = 0;
 
@@ -29,7 +29,7 @@ function tryTimer() {
 function tryListen() {
   console.log('create a server');
   net.createServer()
-    .listen(common.PORT)
+    .listen(0)
     .on('listening', function() {
       revivals++;
       this.close();

test/parallel/test-child-process-disconnect.js

@@ -38,10 +38,10 @@ if (process.argv[2] === 'child') {
 
   // when the server is ready tell parent
   server.on('listening', function() {
-    process.send('ready');
+    process.send({ msg: 'ready', port: server.address().port });
   });
 
-  server.listen(common.PORT);
+  server.listen(0);
 
 } else {
   // testcase
@@ -65,11 +65,11 @@ if (process.argv[2] === 'child') {
   });
 
   // when child is listening
-  child.on('message', function(msg) {
-    if (msg === 'ready') {
+  child.on('message', function(obj) {
+    if (obj && obj.msg === 'ready') {
 
       // connect to child using TCP to know if disconnect was emitted
-      var socket = net.connect(common.PORT);
+      var socket = net.connect(obj.port);
 
       socket.on('data', function(data) {
         data = data.toString();

test/parallel/test-child-process-fork-dgram.js

@@ -72,7 +72,7 @@ if (process.argv[2] === 'child') {
         msg,
         0,
         msg.length,
-        common.PORT,
+        server.address().port,
         '127.0.0.1',
         function(err) {
           if (err) throw err;
@@ -98,7 +98,7 @@ if (process.argv[2] === 'child') {
     client.close();
   };
 
-  server.bind(common.PORT, '127.0.0.1');
+  server.bind(0, '127.0.0.1');
 
   process.once('exit', function() {
     assert(parentGotMessage);

test/parallel/test-child-process-fork-net.js

@@ -1,6 +1,6 @@
 'use strict';
-const assert = require('assert');
 require('../common');
+const assert = require('assert');
 const fork = require('child_process').fork;
 const net = require('net');
 

test/parallel/test-child-process-fork-net2.js

@@ -99,7 +99,7 @@ if (process.argv[2] === 'child') {
 
     var j = count, client;
     while (j--) {
-      client = net.connect(common.PORT, '127.0.0.1');
+      client = net.connect(this.address().port, '127.0.0.1');
       client.on('error', function() {
         // This can happen if we kill the child too early.
         // The client should still get a close event afterwards.
@@ -125,7 +125,7 @@ if (process.argv[2] === 'child') {
     child3.kill();
   }));
 
-  server.listen(common.PORT, '127.0.0.1');
+  server.listen(0, '127.0.0.1');
 
   var closeServer = function() {
     server.close();

test/parallel/test-child-process-fork-regr-gh-2847.js

@@ -25,11 +25,11 @@ var server = net.createServer(function(s) {
   setTimeout(function() {
     s.destroy();
   }, 100);
-}).listen(common.PORT, function() {
+}).listen(0, function() {
   var worker = cluster.fork();
 
   function send(callback) {
-    var s = net.connect(common.PORT, function() {
+    var s = net.connect(server.address().port, function() {
       worker.send({}, s, callback);
     });
 

test/parallel/test-child-process-recv-handle.js

@@ -24,7 +24,7 @@ function master() {
   });
   proc.stdout.on('data', function(data) {
     assert.equal(data, 'ok\r\n');
-    net.createServer(common.fail).listen(common.PORT, function() {
+    net.createServer(common.fail).listen(0, function() {
       handle = this._handle;
       proc.send('one');
       proc.send('two', handle);