Skip to content

Commit a0a61b8

Browse files
yashLadhacodebytere
authored andcommitted
http: used already defined validator for boolean check
We already importing the validator for integer check. So leveraging the boolean check validator to remove already defined logic in the code and thus making it DRY. PR-URL: #33731 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 0dbad26 commit a0a61b8

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

lib/_http_server.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,10 @@ const {
6262
ERR_INVALID_ARG_TYPE,
6363
ERR_INVALID_CHAR
6464
} = require('internal/errors').codes;
65-
const { validateInteger } = require('internal/validators');
65+
const {
66+
validateInteger,
67+
validateBoolean
68+
} = require('internal/validators');
6669
const Buffer = require('buffer').Buffer;
6770
const {
6871
DTRACE_HTTP_SERVER_REQUEST,
@@ -336,11 +339,8 @@ function Server(options, requestListener) {
336339
this.maxHeaderSize = maxHeaderSize;
337340

338341
const insecureHTTPParser = options.insecureHTTPParser;
339-
if (insecureHTTPParser !== undefined &&
340-
typeof insecureHTTPParser !== 'boolean') {
341-
throw new ERR_INVALID_ARG_TYPE(
342-
'options.insecureHTTPParser', 'boolean', insecureHTTPParser);
343-
}
342+
if (insecureHTTPParser !== undefined)
343+
validateBoolean(insecureHTTPParser, 'options.insecureHTTPParser');
344344
this.insecureHTTPParser = insecureHTTPParser;
345345

346346
net.Server.call(this, { allowHalfOpen: true });
@@ -372,9 +372,7 @@ Server.prototype.setTimeout = function setTimeout(msecs, callback) {
372372
return this;
373373
};
374374

375-
Server.prototype[EE.captureRejectionSymbol] = function(
376-
err, event, ...args) {
377-
375+
Server.prototype[EE.captureRejectionSymbol] = function(err, event, ...args) {
378376
switch (event) {
379377
case 'request':
380378
const [ , res] = args;

0 commit comments

Comments
 (0)