Use CHECK_EQ instead of CHECK

davidben · web-flow · commit a3756fe150e9 · 2023-09-20T00:43:15.000-04:00
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -815,7 +815,7 @@ static bool PrintGeneralName(const BIOPointer& out, const GENERAL_NAME* gen) {
 }
 
 bool SafeX509SubjectAltNamePrint(const BIOPointer& out, X509_EXTENSION* ext) {
-  CHECK(OBJ_obj2nid(X509_EXTENSION_get_object(ext)) == NID_subject_alt_name);
+  CHECK_EQ(OBJ_obj2nid(X509_EXTENSION_get_object(ext)), NID_subject_alt_name);
 
   GENERAL_NAMES* names = static_cast<GENERAL_NAMES*>(X509V3_EXT_d2i(ext));
   if (names == nullptr)
@@ -839,7 +839,7 @@ bool SafeX509SubjectAltNamePrint(const BIOPointer& out, X509_EXTENSION* ext) {
 }
 
 bool SafeX509InfoAccessPrint(const BIOPointer& out, X509_EXTENSION* ext) {
-  CHECK(OBJ_obj2nid(X509_EXTENSION_get_object(ext)) == NID_info_access);
+  CHECK_EQ(OBJ_obj2nid(X509_EXTENSION_get_object(ext)), NID_info_access);
 
   AUTHORITY_INFO_ACCESS* descs =
       static_cast<AUTHORITY_INFO_ACCESS*>(X509V3_EXT_d2i(ext));

Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ static bool PrintGeneralName(const BIOPointer& out, const GENERAL_NAME* gen) {`
`815`	`815`	`}`
`816`	`816`
`817`	`817`	`bool SafeX509SubjectAltNamePrint(const BIOPointer& out, X509_EXTENSION* ext) {`
`818`		`- CHECK(OBJ_obj2nid(X509_EXTENSION_get_object(ext)) == NID_subject_alt_name);`
	`818`	`+ CHECK_EQ(OBJ_obj2nid(X509_EXTENSION_get_object(ext)), NID_subject_alt_name);`
`819`	`819`
`820`	`820`	`GENERAL_NAMES* names = static_cast<GENERAL_NAMES*>(X509V3_EXT_d2i(ext));`
`821`	`821`	`if (names == nullptr)`
`@@ -839,7 +839,7 @@ bool SafeX509SubjectAltNamePrint(const BIOPointer& out, X509_EXTENSION* ext) {`
`839`	`839`	`}`
`840`	`840`
`841`	`841`	`bool SafeX509InfoAccessPrint(const BIOPointer& out, X509_EXTENSION* ext) {`
`842`		`- CHECK(OBJ_obj2nid(X509_EXTENSION_get_object(ext)) == NID_info_access);`
	`842`	`+ CHECK_EQ(OBJ_obj2nid(X509_EXTENSION_get_object(ext)), NID_info_access);`
`843`	`843`
`844`	`844`	`AUTHORITY_INFO_ACCESS* descs =`
`845`	`845`	`static_cast<AUTHORITY_INFO_ACCESS*>(X509V3_EXT_d2i(ext));`