Skip to content

Commit a8c1458

Browse files
committed
crypto: add virtual dtor to KeyPairGenerationConfig
Currently the KeyPairGenerationConfigs class has a virtual function but no virtual destructor which means that if delete is called on a KeyPairGenerationConfig pointer to a derived instance, the derived destructor will not get called. The following warning is currently being printed when compiling: warning: delete called on 'node::crypto::KeyPairGenerationConfig' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor] delete __ptr; This commit adds a virtual destructor. PR-URL: #23215 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e5c7f10 commit a8c1458

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node_crypto.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4837,6 +4837,7 @@ class KeyPairGenerationConfig {
48374837
virtual bool Configure(const EVPKeyCtxPointer& ctx) {
48384838
return true;
48394839
}
4840+
virtual ~KeyPairGenerationConfig() {}
48404841
};
48414842

48424843
class RSAKeyPairGenerationConfig : public KeyPairGenerationConfig {

0 commit comments

Comments
 (0)