Skip to content

Commit aebbc96

Browse files
cjihrigMylesBorins
authored andcommitted
test: refactor large event emitter tests
This commit splits several large event emitter tests into smaller block scoped tests. This keeps the tests more isolated. This commit also replaces var with const, assert.equal() with assert.stictEqual(), and other small enhancements. PR-URL: #6446 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent c77ba8c commit aebbc96

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

test/parallel/test-event-emitter-remove-listeners.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
'use strict';
22
const common = require('../common');
33
const assert = require('assert');
4-
const EventEmitter = require('events');
4+
const events = require('events');
55

66
function listener1() {}
77
function listener2() {}
88

99
{
10-
const ee = new EventEmitter();
10+
const ee = new events.EventEmitter();
1111
ee.on('hello', listener1);
1212
ee.on('removeListener', common.mustCall((name, cb) => {
1313
assert.strictEqual(name, 'hello');
@@ -18,15 +18,15 @@ function listener2() {}
1818
}
1919

2020
{
21-
const ee = new EventEmitter();
21+
const ee = new events.EventEmitter();
2222
ee.on('hello', listener1);
2323
ee.on('removeListener', common.fail);
2424
ee.removeListener('hello', listener2);
2525
assert.deepStrictEqual([listener1], ee.listeners('hello'));
2626
}
2727

2828
{
29-
const ee = new EventEmitter();
29+
const ee = new events.EventEmitter();
3030
ee.on('hello', listener1);
3131
ee.on('hello', listener2);
3232
ee.once('removeListener', common.mustCall((name, cb) => {
@@ -46,7 +46,7 @@ function listener2() {}
4646
}
4747

4848
{
49-
const ee = new EventEmitter();
49+
const ee = new events.EventEmitter();
5050

5151
function remove1() {
5252
common.fail('remove1 should not have been called');
@@ -67,7 +67,7 @@ function listener2() {}
6767
}
6868

6969
{
70-
const ee = new EventEmitter();
70+
const ee = new events.EventEmitter();
7171
ee.on('hello', listener1);
7272
ee.on('hello', listener2);
7373
ee.once('removeListener', common.mustCall((name, cb) => {
@@ -87,7 +87,7 @@ function listener2() {}
8787
}
8888

8989
{
90-
const ee = new EventEmitter();
90+
const ee = new events.EventEmitter();
9191
const listener3 = common.mustCall(() => {
9292
ee.removeListener('hello', listener4);
9393
}, 2);
@@ -106,7 +106,7 @@ function listener2() {}
106106
}
107107

108108
{
109-
const ee = new EventEmitter();
109+
const ee = new events.EventEmitter();
110110

111111
ee.once('hello', listener1);
112112
ee.on('removeListener', common.mustCall((eventName, listener) => {

0 commit comments

Comments
 (0)