Skip to content

Commit b38b8d3

Browse files
committed
build: remove redundant Makefile target
The only target that uses the `tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a result of a recent change, it has `tools/doc/node_modules` as a prerequisite, which does the exact same npm install as `tools/doc/node_modules/js-yaml/package.json`. Remove `tools/doc/node_modules/js-yaml/package.json` as unnecessary. PR-URL: #21915 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent c57e11c commit b38b8d3

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -612,11 +612,6 @@ apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_as
612612
.PHONY: doc-only
613613
doc-only: tools/doc/node_modules \
614614
$(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary.
615-
# If it's a source tarball, assets are already in doc/api/assets,
616-
# no need to install anything, we have already copied the docs over
617-
if [ ! -d doc/api/assets ]; then \
618-
$(MAKE) tools/doc/node_modules/js-yaml/package.json; \
619-
fi;
620615
@$(MAKE) out/doc/api/all.html out/doc/api/all.json
621616

622617
.PHONY: doc
@@ -655,9 +650,6 @@ available-node = \
655650
run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock
656651
run-npm-ci = $(PWD)/$(NPM) ci
657652

658-
tools/doc/node_modules/js-yaml/package.json:
659-
cd tools/doc && $(call available-node,$(run-npm-install))
660-
661653
gen-json = tools/doc/generate.js --format=json $< > $@
662654
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \
663655
--analytics=$(DOCS_ANALYTICS) $< > $@

0 commit comments

Comments
 (0)