Skip to content

Commit bbff5a9

Browse files
Trotttargos
authored andcommitted
doc: edit guide on pull requests
* Replace _PR_ with Pull Request * Make some content more concise PR-URL: #39359 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent efe7474 commit bbff5a9

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

doc/guides/contributing/pull-requests.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,7 @@ your name on it. Congratulations and thanks for your contribution!
354354
All Node.js contributors who choose to review and provide feedback on Pull
355355
Requests have a responsibility to both the project and the individual making the
356356
contribution. Reviews and feedback must be helpful, insightful, and geared
357-
towards improving the contribution as opposed to simply blocking it. If there
358-
are reasons why you feel the PR should not land, explain what those are. Do not
357+
towards improving the contribution as opposed to simply blocking it. Do not
359358
expect to be able to block a Pull Request from advancing simply because you say
360359
"No" without giving an explanation. Be open to having your mind changed. Be open
361360
to working with the contributor to make the Pull Request better.
@@ -417,10 +416,8 @@ changes, so that people who may have important input in such a distributed
417416
project are able to respond.
418417

419418
For non-trivial changes, Pull Requests must be left open for at least 48 hours.
420-
In most cases, when the PR is relatively small and focused on a narrow set of
421-
changes, that will provide more than enough time to adequately review. Sometimes
422-
changes take far longer to review, or need more specialized review from subject
423-
matter experts. When in doubt, do not rush.
419+
Sometimes changes take far longer to review, or need more specialized review
420+
from subject-matter experts. When in doubt, do not rush.
424421

425422
Trivial changes, typically limited to small formatting changes or fixes to
426423
documentation, may be landed within the minimum 48 hour window.
@@ -460,11 +457,9 @@ Change requests that are vague, dismissive, or unconstructive may also be
460457
dismissed if requests for greater clarification go unanswered within a
461458
reasonable period of time.
462459

463-
If you do not believe that the Pull Request should land at all, use
464-
`Changes requested` to indicate that you are considering some of your comments
465-
to block the PR from landing. When doing so, explain *why* you believe the
466-
Pull Request should not land along with an explanation of what may be an
467-
acceptable alternative course, if any.
460+
Use `Changes requested` to block a Pull Request from landing. When doing so,
461+
explain why you believe the Pull Request should not land along with an
462+
explanation of what may be an acceptable alternative course, if any.
468463

469464
### Accept that there are different opinions about what belongs in Node.js
470465

0 commit comments

Comments
 (0)