Skip to content

Commit bc718f2

Browse files
authored
fix: only generate embedded.cc under Windows. (#12)
1 parent 8684549 commit bc718f2

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

tools/v8_gypfiles/v8.gyp

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -469,20 +469,22 @@
469469
'<(INTERMEDIATE_DIR)/snapshot.cc',
470470
'<(INTERMEDIATE_DIR)/embedded.cc',
471471
],
472+
'action': [
473+
'<(python)',
474+
'<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
475+
'<@(_inputs)',
476+
'<(INTERMEDIATE_DIR)/embedded.cc', # important: embedded.cc is only ever generated if OS == "win"
477+
],
472478
}],
473479
# Under non-Windows systems, we effectively ignore the output of this
474480
# action. We do need to build snapshot.cc, however.
475481
['OS != "win"', {
476-
'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc']
482+
'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc'],
483+
'action': [],
477484
}],
478485
],
479486
'process_outputs_as_sources': 1,
480-
'action': [
481-
'<(python)',
482-
'<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
483-
'<@(_inputs)',
484-
'<(INTERMEDIATE_DIR)/embedded.cc',
485-
],
487+
486488
},
487489
],
488490
}, # v8_snapshot

0 commit comments

Comments
 (0)