Skip to content

Commit bde26a6

Browse files
danbevjasnell
authored andcommitted
src: remove TODO about uv errno removal
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 9077b48 commit bde26a6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -940,8 +940,6 @@ Local<Value> UVException(Isolate* isolate,
940940

941941
Local<Object> e = Exception::Error(js_msg)->ToObject(isolate);
942942

943-
// TODO(piscisaureus) errno should probably go; the user has no way of
944-
// knowing which uv errno value maps to which error.
945943
e->Set(env->errno_string(), Integer::New(isolate, errorno));
946944
e->Set(env->code_string(), js_code);
947945
e->Set(env->syscall_string(), js_syscall);

0 commit comments

Comments
 (0)