fs: deprecate never throw behaviour in fs.existsSync

Author: Ceres6

doc/api/deprecations.md

@@ -3774,6 +3774,19 @@ Type: Runtime
 
 The `util.getCallSite` API has been removed. Please use [`util.getCallSites()`][] instead.
 
+### DEP0187: `fs.existsSync` never throw on invalid arguments
+
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55753
+    description: Runtime deprecation.
+-->
+
+Type: Runtime
+
+Returning false on validation errors is deprecated.
+
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
 [RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4

lib/fs.js

@@ -149,6 +149,7 @@ const {
   validateString,
   kValidateObjectAllowNullable,
 } = require('internal/validators');
+const { deprecate } = require('internal/util');
 
 const permission = require('internal/process/permission');
 
@@ -276,7 +277,6 @@ ObjectDefineProperty(exists, kCustomPromisifiedSymbol, {
 // the expectation that passing invalid arguments to it, even like
 // fs.existsSync(), would only get a false in return, so we cannot signal
 // validation errors to users properly out of compatibility concerns.
-// TODO(joyeecheung): deprecate the never-throw-on-invalid-arguments behavior
 /**
  * Synchronously tests whether or not the given path exists.
  * @param {string | Buffer | URL} path
@@ -286,6 +286,7 @@ function existsSync(path) {
   try {
     path = getValidatedPath(path);
   } catch {
+    util.deprecate(() => {}, 'never throw on invalid arguments for fs.existsSync is deprecated', 'DEP187');
     return false;
   }